Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 12502: Fix selection after deleting cookies. (Closed)

Created:
12 years ago by Sverrir (Google)
Modified:
9 years, 7 months ago
Reviewers:
Dean McNamee, sky1
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix selection after deleting cookies. The selection was seemingly random because the model to view mapping changed when deleting items. BUG=3692

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M chrome/browser/views/options/cookies_view.cc View 1 1 chunk +15 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sverrir (Google)
*** The first one to see this please review *** Minor change in the options/cookie ...
12 years ago (2008-11-27 18:27:13 UTC) #1
sky
LGTM with the following nit fixed. http://codereview.chromium.org/12502/diff/1/2 File chrome/browser/views/options/cookies_view.cc (right): http://codereview.chromium.org/12502/diff/1/2#newcode293 Line 293: } nit: ...
12 years ago (2008-12-01 16:56:37 UTC) #2
Sverrir (Google)
Fixed and uploaded - could you please submit for me since I can't? Also if ...
12 years ago (2008-12-01 17:57:06 UTC) #3
Dean McNamee
This was committed? Can we close the Rietveld issue? On 2008/12/01 17:57:06, Sverrir wrote: > ...
12 years ago (2008-12-12 13:35:34 UTC) #4
Dean McNamee
12 years ago (2008-12-18 14:43:47 UTC) #5
This was committed, I am closing the review.

On 2008/12/12 13:35:34, Dean McNamee wrote:
> This was committed?  Can we close the Rietveld issue?
> 
> On 2008/12/01 17:57:06, Sverrir wrote:
> > Fixed and uploaded - could you please submit for me since I can't?  Also if
> you
> > would mark the bug as fixed (3692).
> > 
> > Thanks,
> > Sverrir
> > 
> > On 2008/12/01 16:56:37, sky wrote:
> > > LGTM with the following nit fixed.
> > > 
> > > http://codereview.chromium.org/12502/diff/1/2
> > > File chrome/browser/views/options/cookies_view.cc (right):
> > > 
> > > http://codereview.chromium.org/12502/diff/1/2#newcode293
> > > Line 293: }
> > > nit: spacing is off here.

Powered by Google App Engine
This is Rietveld 408576698