Issue 12500008: Eliminate CopyResultsFromDownloadActionCallback(AndQuit).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12500008: Eliminate CopyResultsFromDownloadActionCallback(AndQuit). (Closed)

Created:
7 years, 9 months ago by hidehiko

Modified:
7 years, 9 months ago

Reviewers:
hashimoto, kinaba

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Eliminate CopyResultsFromDownloadActionCallback(AndQuit). Replace the methods with CreateCopyResultCallback, RunAndQuit and CreateComposedCallback. BUG=180569 TEST=Ran unit_tests --gtest_filter=FakeDriveService*:DriveScheduler*:BaseOperationsServer* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189514

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -59 lines)			Patch
M	chrome/browser/chromeos/drive/drive_scheduler_unittest.cc	View	1	4 chunks	+8 lines, -12 lines	0 comments	Download
M	chrome/browser/google_apis/base_operations_server_unittest.cc	View		6 chunks	+17 lines, -22 lines	0 comments	Download
M	chrome/browser/google_apis/fake_drive_service_unittest.cc	View	1	3 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/google_apis/test_util.h	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/google_apis/test_util.cc	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hidehiko

7 years, 9 months ago (2013-03-21 03:41:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r189514 (presubmit successful).

Expand Messages | Collapse Messages