Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1249973002: use sh instead of bash in ProcessUtilTest on linux (Closed)

Created:
5 years, 5 months ago by Mostyn Bramley-Moore
Modified:
5 years, 5 months ago
Reviewers:
brettw, Jing Zhao
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

use sh instead of bash in ProcessUtilTest on linux These unit tests don't seem to really depend on bash, by using sh instead of bash we can run these on more embedded linux targets. Committed: https://crrev.com/69ce035ff23d7712724772dc8eb0379951abb904 Cr-Commit-Position: refs/heads/master@{#339901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/process/process_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@brettw: please take a look. It seems that we use sh on android, so it's ...
5 years, 5 months ago (2015-07-22 11:45:57 UTC) #2
brettw
lgtm
5 years, 5 months ago (2015-07-22 16:03:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249973002/1
5 years, 5 months ago (2015-07-22 16:57:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-22 17:28:17 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 17:28:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69ce035ff23d7712724772dc8eb0379951abb904
Cr-Commit-Position: refs/heads/master@{#339901}

Powered by Google App Engine
This is Rietveld 408576698