Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: runtime/vm/assembler_x64.h

Issue 1249933003: Rename assembler field/getter/setter allow_constant_pool to constant_pool_allowed (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ASSEMBLER_X64_H_ 5 #ifndef VM_ASSEMBLER_X64_H_
6 #define VM_ASSEMBLER_X64_H_ 6 #define VM_ASSEMBLER_X64_H_
7 7
8 #ifndef VM_ASSEMBLER_H_ 8 #ifndef VM_ASSEMBLER_H_
9 #error Do not include assembler_x64.h directly; use assembler.h instead. 9 #error Do not include assembler_x64.h directly; use assembler.h instead.
10 #endif 10 #endif
(...skipping 733 matching lines...) Expand 10 before | Expand all | Expand 10 after
744 // pool pointer is in another register, or that it is not available at all, 744 // pool pointer is in another register, or that it is not available at all,
745 // PP should be passed for pp. 745 // PP should be passed for pp.
746 // TODO(koda): Assert that these are not used for heap objects. 746 // TODO(koda): Assert that these are not used for heap objects.
747 void AddImmediate(Register reg, const Immediate& imm, Register pp); 747 void AddImmediate(Register reg, const Immediate& imm, Register pp);
748 void AddImmediate(const Address& address, const Immediate& imm, Register pp); 748 void AddImmediate(const Address& address, const Immediate& imm, Register pp);
749 void SubImmediate(Register reg, const Immediate& imm, Register pp); 749 void SubImmediate(Register reg, const Immediate& imm, Register pp);
750 void SubImmediate(const Address& address, const Immediate& imm, Register pp); 750 void SubImmediate(const Address& address, const Immediate& imm, Register pp);
751 751
752 void Drop(intptr_t stack_elements, Register tmp = TMP); 752 void Drop(intptr_t stack_elements, Register tmp = TMP);
753 753
754 bool allow_constant_pool() const { 754 bool constant_pool_allowed() const {
755 return allow_constant_pool_; 755 return constant_pool_allowed_;
756 } 756 }
757 void set_allow_constant_pool(bool b) { 757 void set_constant_pool_allowed(bool b) {
758 allow_constant_pool_ = b; 758 constant_pool_allowed_ = b;
759 } 759 }
760 760
761 bool CanLoadImmediateFromPool(const Immediate& imm, Register pp); 761 bool CanLoadImmediateFromPool(const Immediate& imm, Register pp);
762 void LoadImmediate(Register reg, const Immediate& imm, Register pp); 762 void LoadImmediate(Register reg, const Immediate& imm, Register pp);
763 void LoadIsolate(Register dst); 763 void LoadIsolate(Register dst);
764 void LoadObject(Register dst, const Object& obj, Register pp); 764 void LoadObject(Register dst, const Object& obj, Register pp);
765 void LoadUniqueObject(Register dst, const Object& obj, Register pp); 765 void LoadUniqueObject(Register dst, const Object& obj, Register pp);
766 void LoadExternalLabel(Register dst, 766 void LoadExternalLabel(Register dst,
767 const ExternalLabel* label, 767 const ExternalLabel* label,
768 Patchability patchable, 768 Patchability patchable,
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
1066 const String& comment() const { return comment_; } 1066 const String& comment() const { return comment_; }
1067 1067
1068 private: 1068 private:
1069 intptr_t pc_offset_; 1069 intptr_t pc_offset_;
1070 const String& comment_; 1070 const String& comment_;
1071 1071
1072 DISALLOW_COPY_AND_ASSIGN(CodeComment); 1072 DISALLOW_COPY_AND_ASSIGN(CodeComment);
1073 }; 1073 };
1074 1074
1075 GrowableArray<CodeComment*> comments_; 1075 GrowableArray<CodeComment*> comments_;
1076 bool allow_constant_pool_; 1076 bool constant_pool_allowed_;
1077 1077
1078 intptr_t FindImmediate(int64_t imm); 1078 intptr_t FindImmediate(int64_t imm);
1079 bool CanLoadFromObjectPool(const Object& object) const; 1079 bool CanLoadFromObjectPool(const Object& object) const;
1080 void LoadObjectHelper(Register dst, 1080 void LoadObjectHelper(Register dst,
1081 const Object& obj, 1081 const Object& obj,
1082 Register pp, 1082 Register pp,
1083 bool is_unique); 1083 bool is_unique);
1084 void LoadWordFromPoolOffset(Register dst, Register pp, int32_t offset); 1084 void LoadWordFromPoolOffset(Register dst, Register pp, int32_t offset);
1085 1085
1086 inline void EmitUint8(uint8_t value); 1086 inline void EmitUint8(uint8_t value);
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
1214 } 1214 }
1215 1215
1216 1216
1217 inline void Assembler::EmitOperandSizeOverride() { 1217 inline void Assembler::EmitOperandSizeOverride() {
1218 EmitUint8(0x66); 1218 EmitUint8(0x66);
1219 } 1219 }
1220 1220
1221 } // namespace dart 1221 } // namespace dart
1222 1222
1223 #endif // VM_ASSEMBLER_X64_H_ 1223 #endif // VM_ASSEMBLER_X64_H_
OLDNEW
« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698