LayoutTests/fast/canvas/script-tests/canvas-getContext-invalid.js - Issue 1249913003: The contextId argument for HTMLCanvasElement getContext() api should not be optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/canvas/script-tests/canvas-getContext-invalid.js

Issue 1249913003: The contextId argument for HTMLCanvasElement getContext() api should not be optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/canvas-getContext-invalid-expected.txt ('k') | LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/canvas/script-tests/canvas-getContext-invalid.js

diff --git a/LayoutTests/fast/canvas/script-tests/canvas-getContext-invalid.js b/LayoutTests/fast/canvas/script-tests/canvas-getContext-invalid.js

index b957468524408c17633e729a1b70225080dfd3e0..dec12679ad24d825856905bb1fe137784ae253ed 100644

--- a/LayoutTests/fast/canvas/script-tests/canvas-getContext-invalid.js

+++ b/LayoutTests/fast/canvas/script-tests/canvas-getContext-invalid.js

@@ -8,3 +8,6 @@ shouldBe("canvas.getContext('This is clearly not a valid context name.')", "null

shouldBe("canvas.getContext('2d\0')", "null");

shouldBe("canvas.getContext('2\uFF44')", "null");

shouldBe("canvas.getContext('2D')", "null");

+shouldThrow("canvas.getContext()");

+shouldBe("canvas.getContext('null')", "null");

+shouldBe("canvas.getContext('undefined')", "null");