Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1249913003: The contextId argument for HTMLCanvasElement getContext() api should not be optional (Closed)

Created:
5 years, 5 months ago by shiva.jm
Modified:
5 years, 5 months ago
Reviewers:
tkent, philipj_slow
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

The contextId argument for HTMLCanvasElement getContext() api should not be optional As per spec link: https://html.spec.whatwg.org/#the-canvas-element, contextId argument for HTMLCanvasElement getContext() api should not be optional. Firefox and IE throws TypeError:Not enough arguments, if argument is missing. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199308

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M LayoutTests/fast/canvas/canvas-getContext-invalid-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-getContext-invalid.js View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js View 1 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
shiva.jm
pls have a look.
5 years, 5 months ago (2015-07-22 08:35:26 UTC) #2
philipj_slow
LGTM % nit https://codereview.chromium.org/1249913003/diff/1/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js File LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js (right): https://codereview.chromium.org/1249913003/diff/1/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js#newcode177 LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js:177: var canvas = document.createElement("canvas"); Just return ...
5 years, 5 months ago (2015-07-22 09:19:15 UTC) #3
shiva.jm
updated the tests, pls have a look. https://codereview.chromium.org/1249913003/diff/1/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js File LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js (right): https://codereview.chromium.org/1249913003/diff/1/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js#newcode177 LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js:177: var canvas ...
5 years, 5 months ago (2015-07-22 09:31:41 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249913003/20001
5 years, 5 months ago (2015-07-22 09:34:10 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-22 10:54:59 UTC) #12
philipj_slow
lgtm
5 years, 5 months ago (2015-07-22 11:20:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249913003/20001
5 years, 5 months ago (2015-07-22 11:20:24 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 11:23:45 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199308

Powered by Google App Engine
This is Rietveld 408576698