sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart - Issue 12499005: dart2js: Create noSuchMethod handlers at runtime to reduce overhead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

Issue 12499005: dart2js: Create noSuchMethod handlers at runtime to reduce overhead. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Reordered some stuff due to code review feedback Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart b/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

index 52a237c0d6b02730bf714f8b1dc8104f0f999b39..4d27f893db20c87c1f21ba5d849c1c23c3002fa0 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

@@ -11,6 +11,7 @@ class CodeEmitterNoEvalTask extends CodeEmitterTask {

: super(compiler, namer, generateSourceMap);

bool get getterAndSetterCanBeImplementedByFieldSpec => false;

+ bool get generateTrivialNsmHandlers => false;

void emitSuper(String superName, ClassBuilder builder) {

if (superName != '') {

@@ -115,7 +116,7 @@ class CodeEmitterNoEvalTask extends CodeEmitterTask {

js.fun([], [

js['var hasOwnProperty = Object.prototype.hasOwnProperty'],

js.forIn('staticName', 'isolateProperties',

- js.if_(js['hasOwnProperty.call(isolateProperties, staticName)'],

+ js.if_('hasOwnProperty.call(isolateProperties, staticName)',

js['this[staticName] = isolateProperties[staticName]'])),

// Use the newly created object as prototype. In Chrome,

// this creates a hidden class for the object and makes