Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1566)

Unified Diff: src/spaces.cc

Issue 12499004: Unlink evacuation candidates from list of pages before starting sweeper threads. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/spaces.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/spaces.cc
diff --git a/src/spaces.cc b/src/spaces.cc
index 1861c5340391d50db9d7c2ac3e51ce6dd6f2d0da..701d46f38bc63473e56cc367caddabfc210f8657 100644
--- a/src/spaces.cc
+++ b/src/spaces.cc
@@ -981,6 +981,7 @@ bool PagedSpace::CanExpand() {
return true;
}
+
bool PagedSpace::Expand() {
if (!CanExpand()) return false;
@@ -1045,7 +1046,7 @@ int PagedSpace::CountTotalPages() {
}
-void PagedSpace::ReleasePage(Page* page) {
+void PagedSpace::ReleasePage(Page* page, bool unlink) {
ASSERT(page->LiveBytes() == 0);
ASSERT(AreaSize() == page->area_size());
@@ -1069,7 +1070,9 @@ void PagedSpace::ReleasePage(Page* page) {
allocation_info_.top = allocation_info_.limit = NULL;
}
- page->Unlink();
+ if (unlink) {
+ page->Unlink();
+ }
if (page->IsFlagSet(MemoryChunk::CONTAINS_ONLY_DATA)) {
heap()->isolate()->memory_allocator()->Free(page);
} else {
@@ -2555,7 +2558,6 @@ bool PagedSpace::EnsureSweeperProgress(intptr_t size_in_bytes) {
if (collector->StealMemoryFromSweeperThreads(this) < size_in_bytes) {
if (!collector->sequential_sweeping()) {
collector->WaitUntilSweepingCompleted();
- collector->FinalizeSweeping();
return true;
}
}
« no previous file with comments | « src/spaces.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698