service/rawdatastore/datastore_impl.go - Issue 1249863004: Remove most error code from luci/gae

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/rawdatastore/datastore_impl.go

Issue 1249863004: Remove most error code from luci/gae (Closed) Base URL: https://github.com/luci/gae.git@simplify_rds

Patch Set: get rid of goofy lerrs imports Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/rawdatastore/datastore_impl.go

diff --git a/service/rawdatastore/datastore_impl.go b/service/rawdatastore/datastore_impl.go

index 2c8980442c9733a7dbd6032421c81811e14c9c92..2ea0ae9e161766ff3087f39318f8bee80643eb69 100644

--- a/service/rawdatastore/datastore_impl.go

+++ b/service/rawdatastore/datastore_impl.go

@@ -7,7 +7,6 @@

package rawdatastore

import (

- "errors"

"fmt"

"reflect"

"strconv"

@@ -16,8 +15,8 @@ import (

"time"

"unicode"

- "github.com/luci/gae"

"github.com/luci/gae/service/blobstore"

+ "github.com/luci/luci-go/common/errors"

)

// Entities with more than this many indexed properties will not be saved.

@@ -60,7 +59,7 @@ func (p *structPLS) Load(propMap PropertyMap) error {

return err

}

- convFailures := gae.MultiError(nil)

+ convFailures := errors.MultiError(nil)

t := reflect.Type(nil)

for name, props := range propMap {

« no previous file with comments | « impl/prod/taskqueue.go ('k') | upstream_errors.go » ('j') | no next file with comments »