Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1249823002: Revert of Parse HPKP report-uri and persist in TransportSecurityPersister (Closed)

Created:
5 years, 5 months ago by Ryan Sleevi
Modified:
5 years, 5 months ago
Reviewers:
eroman, davidben, estark
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Parse HPKP report-uri and persist in TransportSecurityPersister (patchset #11 id:200001 of https://codereview.chromium.org/1211363005/) Reason for revert: Causes Win7 to hang Original issue's description: > Parse HPKP report-uri and persist in TransportSecurityPersister > > This CL parses the report-uri attribute on HPKP headers and stores them > in TransportSecurityPersister. > > This is CL #1. > CL #2: crrev.com/1212973002 (add net::CertificateReportSender) > CL #3: crrev.com/1212613004 (add net::TransportSecurityReporter) > CL #4: crrev.com/1213783005 (send HPKP reports) > > BUG=445793 > > Committed: https://crrev.com/1320e36d908427d615357df1630348bfb38cb5c4 > Cr-Commit-Position: refs/heads/master@{#339667} TBR=davidben@chromium.org,eroman@chromium.org,estark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=445793 Committed: https://crrev.com/ebc4df76fef37fb51415c23d84af590e48a93069 Cr-Commit-Position: refs/heads/master@{#339759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -438 lines) Patch
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_security_headers.h View 3 chunks +1 line, -5 lines 0 comments Download
M net/http/http_security_headers.cc View 5 chunks +57 lines, -63 lines 0 comments Download
M net/http/http_security_headers_unittest.cc View 9 chunks +87 lines, -189 lines 0 comments Download
M net/http/http_util.h View 4 chunks +8 lines, -19 lines 0 comments Download
M net/http/http_util.cc View 4 chunks +48 lines, -27 lines 0 comments Download
M net/http/http_util_unittest.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M net/http/transport_security_persister.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M net/http/transport_security_persister_unittest.cc View 7 chunks +5 lines, -11 lines 0 comments Download
M net/http/transport_security_state.h View 4 chunks +2 lines, -9 lines 0 comments Download
M net/http/transport_security_state.cc View 4 chunks +6 lines, -13 lines 0 comments Download
M net/http/transport_security_state_unittest.cc View 16 chunks +19 lines, -49 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
Created Revert of Parse HPKP report-uri and persist in TransportSecurityPersister
5 years, 5 months ago (2015-07-21 22:02:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249823002/1
5 years, 5 months ago (2015-07-21 22:03:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 22:05:26 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 22:07:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebc4df76fef37fb51415c23d84af590e48a93069
Cr-Commit-Position: refs/heads/master@{#339759}

Powered by Google App Engine
This is Rietveld 408576698