Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2150)

Unified Diff: pkg/analysis_server/benchmark/integration/driver.dart

Issue 1249793007: performance measurement mods: (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/benchmark/integration/input_converter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/benchmark/integration/driver.dart
diff --git a/pkg/analysis_server/benchmark/integration/driver.dart b/pkg/analysis_server/benchmark/integration/driver.dart
index 19243ea799ed729415dfb2282706a831dca1a6a6..a3167810948f9d47ec99c00bdfb2735c0f7d86f3 100644
--- a/pkg/analysis_server/benchmark/integration/driver.dart
+++ b/pkg/analysis_server/benchmark/integration/driver.dart
@@ -7,7 +7,6 @@ library server.driver;
import 'dart:async';
import 'dart:math' show max, sqrt;
-import 'package:analyzer/src/generated/engine.dart' as engine;
import 'package:logging/logging.dart';
import '../../test/integration/integration_test_methods.dart';
@@ -44,7 +43,14 @@ class Driver extends IntegrationTestMixin {
*/
static const Duration SHUTDOWN_TIMEOUT = const Duration(seconds: 5);
- final Logger logger;
+ final Logger logger = new Logger('Driver');
+
+ final bool newTaskModel;
+
+ /**
+ * The diagnostic port for Analysis Server or `null` if none.
+ */
+ final int diagnosticPort;
/**
* A flag indicating whether the server is running.
@@ -64,7 +70,7 @@ class Driver extends IntegrationTestMixin {
*/
Completer<Results> _runCompleter = new Completer<Results>();
- Driver(this.logger);
+ Driver({this.newTaskModel, this.diagnosticPort});
/**
* Return a [Future] that completes with the [Results] of running
@@ -97,7 +103,7 @@ class Driver extends IntegrationTestMixin {
* Launch the analysis server.
* Return a [Future] that completes when analysis server has started.
*/
- Future startServer({int diagnosticPort}) async {
+ Future startServer() async {
logger.log(Level.FINE, 'starting server');
initializeInttestMixin();
server = new Server();
@@ -108,7 +114,9 @@ class Driver extends IntegrationTestMixin {
});
running = true;
return server
- .start(diagnosticPort: diagnosticPort /*profileServer: true*/)
+ .start(
+ diagnosticPort: diagnosticPort,
+ newTaskModel: newTaskModel /*profileServer: true*/)
.then((params) {
server.listenToOutput(dispatchNotification);
server.exitCode.then((_) {
@@ -193,7 +201,7 @@ class Measurement {
_printDuration(sb, new Duration(microseconds: meanTime));
_printDuration(sb, time90th);
_printDuration(sb, time99th);
- _printColumn(sb, standardDeviation.toString(), 15, rightJustified: true);
+ _printDuration(sb, new Duration(microseconds: standardDeviation));
_printDuration(sb, minTime);
_printDuration(sb, maxTime);
_printDuration(sb, new Duration(microseconds: totalTimeMicros));
@@ -212,9 +220,8 @@ class Measurement {
}
void _printDuration(StringBuffer sb, Duration duration) {
- sb.write(' ');
- sb.write(duration);
- sb.write(',');
+ _printColumn(sb, duration.inMilliseconds.toString(), 15,
+ rightJustified: true);
}
}
@@ -231,11 +238,6 @@ class Results {
void printResults() {
print('');
print('==================================================================');
- if (engine.AnalysisEngine.instance.useTaskModel) {
- print('New task model');
- } else {
- print('Old task model');
- }
print('');
List<String> keys = measurements.keys.toList()..sort();
int keyLen = keys.fold(0, (int len, String key) => max(len, key.length));
@@ -263,11 +265,11 @@ class Results {
}
}
/// TODO(danrubel) *** print warnings if driver caches are not empty ****
- print('');
- print(
- '(1) uxr = UneXpected Results, or responses received from the server');
- print(
- ' that do not match the recorded response for that request.');
+ print('''
+
+(1) uxr = UneXpected Results or responses received from the server
+ that do not match the recorded response for that request.
+(2) all times in milliseconds''');
}
/**
@@ -294,7 +296,7 @@ class Results {
_printColumn(sb, 'error', 6, rightJustified: true);
_printColumn(sb, 'uxr(1)', 6, rightJustified: true);
sb.write(' ');
- _printColumn(sb, 'mean', 15);
+ _printColumn(sb, 'mean(2)', 15);
_printColumn(sb, '90th', 15);
_printColumn(sb, '99th', 15);
_printColumn(sb, 'std-dev', 15);
« no previous file with comments | « no previous file | pkg/analysis_server/benchmark/integration/input_converter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698