Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1249793003: Revert of [Andorid] Migrate to ClipDrawable progress bar. (Closed)

Created:
5 years, 5 months ago by Kibeom Kim (inactive)
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Andorid] Migrate to ClipDrawable progress bar. (patchset #35 id:670001 of https://codereview.chromium.org/1170843002/) Reason for revert: Chrome Shell tests flaky. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests I think I know where I made a mistake and it should be a simple few line fix but to make sure... Original issue's description: > [Andorid] Migrate to ClipDrawable progress bar. > > Using ClipDrawable progress bar helps future changes for > http://crbug.com/461148 as we only need pass to color parameters. > > Also it has minor performance benefit. > > BUG=466140, 455891, 461148 > > Committed: https://crrev.com/ee231168bb231ee117485ecd1e7cb16a1f632bae > Cr-Commit-Position: refs/heads/master@{#339598} TBR=tedchoc@chromium.org,dtrainor@chromium.org,newt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466140, 455891, 461148 Committed: https://crrev.com/1a3897c2ebfca0156273584df8779bc56a0641a0 Cr-Commit-Position: refs/heads/master@{#339742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+502 lines, -570 lines) Patch
A chrome/android/java/res/drawable/progress_bar.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/android/java/res/drawable/progress_bar_white.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/android/java/res/layout/custom_tabs_toolbar.xml View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/android/java/res/layout/toolbar.xml View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/res/values/attrs.xml View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java View 4 chunks +77 lines, -35 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarDataProvider.java View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java View 6 chunks +15 lines, -31 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java View 7 chunks +93 lines, -82 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 3 chunks +16 lines, -12 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/widget/ClipDrawableProgressBar.java View 1 chunk +0 lines, -248 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java View 2 chunks +143 lines, -60 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/QueryInOmniboxTest.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java View 2 chunks +37 lines, -59 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java View 4 chunks +18 lines, -11 lines 0 comments Download
A chrome/android/shell/res/drawable/shell_progress_bar.xml View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/android/shell/res/layout/chrome_shell_activity.xml View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceAdapter.java View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kibeom Kim (inactive)
Created Revert of [Andorid] Migrate to ClipDrawable progress bar.
5 years, 5 months ago (2015-07-21 20:36:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249793003/1
5 years, 5 months ago (2015-07-21 20:37:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 20:39:28 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 20:42:25 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a3897c2ebfca0156273584df8779bc56a0641a0
Cr-Commit-Position: refs/heads/master@{#339742}

Powered by Google App Engine
This is Rietveld 408576698