Issue 1249773004: Clean up more SkXfermode.cpp dead code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1249773004: Clean up more SkXfermode.cpp dead code. (Closed)

Created:
5 years, 5 months ago by mtklein_C

Modified:
5 years, 5 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Clean up more SkXfermode.cpp dead code. These handwritten xfermodes for Clear, Src, DstIn, and DstOut are actually dead code: they're all covered by Sk4pxXfermode, which we'd already have returned. Tidies up the xfermode creation logic to make this clearer. This cuts 20-40K off SkXfermode.o, depending on the platform. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4c4b84c0051e5126f17e55e0d5b61b5ad8c7d301

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -254 lines)			Patch
	M	src/core/SkXfermode.cpp	View		2 chunks	+9 lines, -254 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249773004/1

5 years, 5 months ago (2015-07-21 19:52:48 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-21 20:10:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4c4b84c0051e5126f17e55e0d5b61b5ad8c7d301

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages