Issue 124973004: Use data:, rather than about:blank as a substitute form action so the resulting blank page will hav…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 124973004: Use data:, rather than about:blank as a substitute form action so the resulting blank page will hav… (Closed)

Created:
6 years, 11 months ago by Tom Sepez

Modified:
6 years, 11 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use data:, rather than about:blank as a substitute form action so the resulting blank page will have an unique origin. This is similar to the work we did in XSSAuditorDelegate for the mode=block case, where we used the SecurityOrigin::urlWithUniqueOrign constant. We can't use that here due to threading. Testing is covered by rebasing the existing test cases. BUG=331060 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164538

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -6 lines)			Patch
M	LayoutTests/http/tests/security/xssAuditor/form-action-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/security/xssAuditor/formaction-on-button-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/security/xssAuditor/formaction-on-input-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/parser/XSSAuditor.cpp	View	4 chunks	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/124973004/1

6 years, 11 months ago (2014-01-06 22:24:47 UTC) #3

Message was sent while issue was closed.

Change committed as 164538

Expand Messages | Collapse Messages