Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 124973002: Cleanup - Get rid of unnecessary local variables. (Closed)

Created:
6 years, 11 months ago by vanihegde
Modified:
6 years, 11 months ago
CC:
blink-reviews, vani
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Cleanup - Get rid of unnecessary local variables. Trivial cleanup patch to get rid of not needed local variables. TESTS=No tests as there is no behavior change. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164615

Patch Set 1 #

Total comments: 5

Patch Set 2 : Cleanup patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M Source/core/editing/ApplyStyleCommand.cpp View 1 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vanihegde
Minor change, please take a look. Thanks. https://codereview.chromium.org/124973002/diff/1/Source/core/editing/ApplyStyleCommand.cpp File Source/core/editing/ApplyStyleCommand.cpp (left): https://codereview.chromium.org/124973002/diff/1/Source/core/editing/ApplyStyleCommand.cpp#oldcode399 Source/core/editing/ApplyStyleCommand.cpp:399: currentFontSize = ...
6 years, 11 months ago (2014-01-06 09:01:37 UTC) #1
ojan
https://codereview.chromium.org/124973002/diff/1/Source/core/editing/ApplyStyleCommand.cpp File Source/core/editing/ApplyStyleCommand.cpp (left): https://codereview.chromium.org/124973002/diff/1/Source/core/editing/ApplyStyleCommand.cpp#oldcode399 Source/core/editing/ApplyStyleCommand.cpp:399: currentFontSize = computedFontSize(node); On 2014/01/06 09:01:37, vanihegde wrote: > ...
6 years, 11 months ago (2014-01-06 18:55:41 UTC) #2
vanihegde
https://codereview.chromium.org/124973002/diff/1/Source/core/editing/ApplyStyleCommand.cpp File Source/core/editing/ApplyStyleCommand.cpp (left): https://codereview.chromium.org/124973002/diff/1/Source/core/editing/ApplyStyleCommand.cpp#oldcode399 Source/core/editing/ApplyStyleCommand.cpp:399: currentFontSize = computedFontSize(node); On 2014/01/06 18:55:41, ojan wrote: > ...
6 years, 11 months ago (2014-01-07 08:30:46 UTC) #3
ojan
lgtm
6 years, 11 months ago (2014-01-07 18:38:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/124973002/60001
6 years, 11 months ago (2014-01-07 18:39:10 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 21:31:39 UTC) #6
Message was sent while issue was closed.
Change committed as 164615

Powered by Google App Engine
This is Rietveld 408576698