Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 1249723005: Remove code for no longer present external array on any object API (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove code for no longer present external array on any object API BUG=v8:3996 R=jarin@chromium.org LOG=n Committed: https://crrev.com/7bedb50f7dac35e00e73fc41f62310c795a6eb24 Cr-Commit-Position: refs/heads/master@{#29808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M src/objects.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-07-23 09:04:51 UTC) #1
Jarin
lgtm
5 years, 5 months ago (2015-07-23 12:38:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249723005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1249723005/1
5 years, 5 months ago (2015-07-23 12:38:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 12:49:02 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 12:49:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bedb50f7dac35e00e73fc41f62310c795a6eb24
Cr-Commit-Position: refs/heads/master@{#29808}

Powered by Google App Engine
This is Rietveld 408576698