Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1249693003: Rename angle_deqp_tests to angle_deqp_gles2_tests. (Closed)

Created:
5 years, 5 months ago by Jamie Madill
Modified:
5 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename angle_deqp_tests to angle_deqp_gles2_tests. This will allow us to make a new angle_deqp_gles3_tests target. Temporarily include two expectations files in the isolate, until we can make the switch in ANGLE, then disable the older file. Will require us to take the deqp_tests offline temporarily, or switch them very quickly after this lands, so we don't get any broken builds which look for the older names. BUG=510822 TEST=bots, manual testing with isolates. NOPRESUBMIT=true Committed: https://crrev.com/5fc297fb2b3587f8474df4dba5cd25c8d55f4fa8 Cr-Commit-Position: refs/heads/master@{#339903}

Patch Set 1 #

Patch Set 2 : Update test expectations file #

Patch Set 3 : Include both expectations files temporarily #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -33 lines) Patch
A + chrome/angle_deqp_gles2_tests.isolate View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
D chrome/angle_deqp_tests.isolate View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 24 (7 generated)
Jamie Madill
piman@chromium.org: Please review changes in chrome/ maruel@chromium.org: Please review changes in gpu/ Added Ken as ...
5 years, 5 months ago (2015-07-21 20:56:20 UTC) #2
Ken Russell (switch to Gerrit)
LGTM. Since this will break the Windows builder on chromium.gpu.fyi and therefore prevent any tests ...
5 years, 5 months ago (2015-07-21 21:02:19 UTC) #3
Jamie Madill
Ken, yeah, that's the plan, see https://codereview.chromium.org/1238313002/. If this patch LG to the owners, I'll ...
5 years, 5 months ago (2015-07-21 21:07:31 UTC) #4
piman
lgtm
5 years, 5 months ago (2015-07-21 22:58:52 UTC) #5
M-A Ruel
lgtm
5 years, 5 months ago (2015-07-22 14:00:32 UTC) #6
Jamie Madill
Thanks for reviews. Landing.
5 years, 5 months ago (2015-07-22 14:08:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249693003/40001
5 years, 5 months ago (2015-07-22 14:08:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/80937)
5 years, 5 months ago (2015-07-22 14:16:58 UTC) #11
Jamie Madill
Hm, whose LGTM am I missing here?
5 years, 5 months ago (2015-07-22 14:23:05 UTC) #12
Jamie Madill
@vadimsh, PTAL at the change to the isolate files.
5 years, 5 months ago (2015-07-22 14:26:15 UTC) #14
Vadim Sh.
lgtm, though M-A's lgtm should be as powerful as mine regarding OWNERS
5 years, 5 months ago (2015-07-22 15:29:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249693003/40001
5 years, 5 months ago (2015-07-22 17:00:57 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/80999)
5 years, 5 months ago (2015-07-22 17:10:36 UTC) #19
Jamie Madill
re-landing with NOPRESUBMIT=true
5 years, 5 months ago (2015-07-22 17:27:34 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249693003/40001
5 years, 5 months ago (2015-07-22 17:27:59 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-22 17:29:42 UTC) #23
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 17:30:12 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5fc297fb2b3587f8474df4dba5cd25c8d55f4fa8
Cr-Commit-Position: refs/heads/master@{#339903}

Powered by Google App Engine
This is Rietveld 408576698