Improve the about/discards UI, allowing each tab to be individually closed.

chrome/browser/memory/oom_priority_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEMORY_OOM_PRIORITY_MANAGER_H_
 #define CHROME_BROWSER_MEMORY_OOM_PRIORITY_MANAGER_H_
 
 #include <utility>
 #include <vector>
 
@@ skipping 38 matching lines @@
 
   // Number of discard events since Chrome started.
   int discard_count() const { return discard_count_; }
 
   // See member comment.
   bool recent_tab_discard() const { return recent_tab_discard_; }
 
   void Start();
   void Stop();
 
-  // Returns list of tab titles sorted from most interesting (don't kill)
-  // to least interesting (OK to kill).
-  std::vector<base::string16> GetTabTitles();
+  // Returns the list of the stats for all renderers.

[Georges Khalil, 2015/07/21 18:13:37]

nit: Add "Must be called on UI thread." (not implicit anymore, because of name
change).

[proberge, 2015/07/21 18:29:06]

Done.

+  TabStatsList GetTabStats();
 
   // Discards a tab to free the memory occupied by its renderer.
   // Tab still exists in the tab-strip; clicking on it will reload it.
   // Returns true if it successfully found a tab and discarded it.
   bool DiscardTab();
 
+  // Discards a tab with the given unique ID.

[Georges Khalil, 2015/07/21 18:13:37]

nit: Fix wrap.

[proberge, 2015/07/21 18:29:06]

Done.

+  // The tab still exists in the tab-strip; clicking on it will reload it.
+  // Returns true if it successfully found a tab and discarded it.

[Georges Khalil, 2015/07/21 18:13:37]

Better comments, good! :)

[proberge, 2015/07/21 18:29:06]

Acknowledged.

+  bool DiscardTabById(int64 target_web_contents_id);
+
   // Log memory statistics for the running processes, then discards a tab.
   // Tab discard happens sometime later, as collecting the statistics touches
   // multiple threads and takes time.
   void LogMemoryAndDiscardTab();
 
   // Log memory statistics for the running processes, then call the callback.
   void LogMemory(const std::string& title, const base::Closure& callback);
 
  private:
   FRIEND_TEST_ALL_PREFIXES(OomPriorityManagerTest, Comparator);
   FRIEND_TEST_ALL_PREFIXES(OomPriorityManagerTest, IsInternalPage);
 
   static void PurgeMemoryAndDiscardTab();
 
   // Returns true if the |url| represents an internal Chrome web UI page that
   // can be easily reloaded and hence makes a good choice to discard.
   static bool IsInternalPage(const GURL& url);
 
-  // Discards a tab with the given unique ID. Returns true if discard occurred.
-  bool DiscardTabById(int64 target_web_contents_id);
-
   // Records UMA histogram statistics for a tab discard. We record statistics
   // for user triggered discards via chrome://discards/ because that allows us
   // to manually test the system.
   void RecordDiscardStatistics();
 
   // Record whether we ran out of memory during a recent time interval.
   // This allows us to normalize low memory statistics versus usage.
   void RecordRecentTabDiscard();
 
   // Purges data structures in the browser that can be easily recomputed.
   void PurgeBrowserMemory();
 
   // Returns the number of tabs open in all browser instances.
   int GetTabCount() const;
 
-  // Returns the list of the stats for all renderers.
-  TabStatsList GetTabStatsOnUIThread();
-
   // Adds all the stats of the tabs in |browser_list| into |stats_list|. If
   // |active_desktop| is true, we consider its first window as being active.
   void AddTabStats(BrowserList* browser_list,
                    bool active_desktop,
                    TabStatsList* stats_list);
 
   // Callback for when |update_timer_| fires. Takes care of executing the tasks
   // that need to be run periodically (see comment in implementation).
   void UpdateTimerCallback();
 
@@ skipping 34 matching lines @@
 #if defined(OS_CHROMEOS)
   scoped_ptr<OomPriorityManagerDelegate> delegate_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(OomPriorityManager);
 };
 
 }  // namespace memory
 
 #endif  // CHROME_BROWSER_MEMORY_OOM_PRIORITY_MANAGER_H_