Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3994)

Unified Diff: base/trace_event/trace_event_argument.cc

Issue 1249643007: Align base::Pickle allocations to 4k boundaries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@accounting_fix
Patch Set: Nits test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/trace_event_argument.cc
diff --git a/base/trace_event/trace_event_argument.cc b/base/trace_event/trace_event_argument.cc
index 14a4499c1f6c52e0084b1c3cdfd7f1580d94337a..f77209d9493ada951dfb79da72c9428498011e7b 100644
--- a/base/trace_event/trace_event_argument.cc
+++ b/base/trace_event/trace_event_argument.cc
@@ -4,6 +4,7 @@
#include "base/trace_event/trace_event_argument.h"
+#include "base/bits.h"
#include "base/json/json_writer.h"
#include "base/trace_event/trace_event_memory_overhead.h"
#include "base/values.h"
@@ -453,9 +454,14 @@ void TracedValue::AppendAsTraceFormat(std::string* out) const {
void TracedValue::EstimateTraceMemoryOverhead(
TraceEventMemoryOverhead* overhead) {
+ const size_t kPickleHeapAlign = 4096; // Must be == Pickle::kPickleHeapAlign.
overhead->Add("TracedValue",
- pickle_.GetTotalAllocatedSize() /* allocated size */,
- pickle_.size() /* resident size */);
+
+ /* allocated size */
+ bits::Align(pickle_.GetTotalAllocatedSize(), kPickleHeapAlign),
+
+ /* resident size */
+ bits::Align(pickle_.size(), kPickleHeapAlign));
}
} // namespace trace_event

Powered by Google App Engine
This is Rietveld 408576698