media/mojo/services/service_factory_impl.cc - Issue 1249643004: media: Quit MojoMediaApplication when no ServiceFactory service is bound.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/services/service_factory_impl.cc

Issue 1249643004: media: Quit MojoMediaApplication when no ServiceFactory service is bound. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/mojo/services/service_factory_impl.h ('k') | mojo/application/public/cpp/application_impl.h » ('j') | mojo/application/public/cpp/application_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/mojo/services/service_factory_impl.cc

diff --git a/media/mojo/services/service_factory_impl.cc b/media/mojo/services/service_factory_impl.cc

index 09554ee6a90d0fa6b0c35a2167eac6fd4a9ba0d4..45109f1d415986785031c7dd1432f23c70237ac7 100644

--- a/media/mojo/services/service_factory_impl.cc

+++ b/media/mojo/services/service_factory_impl.cc

@@ -11,16 +11,19 @@

#include "media/mojo/services/mojo_cdm_service.h"

#include "media/mojo/services/mojo_media_client.h"

#include "media/mojo/services/mojo_renderer_service.h"

+#include "mojo/application/public/cpp/app_lifetime_helper.h"

namespace media {

ServiceFactoryImpl::ServiceFactoryImpl(

mojo::InterfaceRequest<interfaces::ServiceFactory> request,

mojo::ServiceProvider* service_provider,

- scoped_refptr<MediaLog> media_log)

+ scoped_refptr<MediaLog> media_log,

+ scoped_ptr<mojo::AppRefCount> parent_app_refcount)

: binding_(this, request.Pass()),

service_provider_(service_provider),

- media_log_(media_log) {

+ media_log_(media_log),

+ parent_app_refcount_(parent_app_refcount.Pass()) {

DVLOG(1) << __FUNCTION__;

}