fpdfsdk/include/javascript/JS_Define.h - Issue 1249643003: Remove dead code found by Scythe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/javascript/JS_Define.h

Issue 1249643003: Remove dead code found by Scythe. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/javascript/JS_Define.h

diff --git a/fpdfsdk/include/javascript/JS_Define.h b/fpdfsdk/include/javascript/JS_Define.h

index dabcb0645aa8600a4f413ec8391d06369e880fba..f1b36bf3d0c1720113c6eaca1c6458436f88c3ea 100644

--- a/fpdfsdk/include/javascript/JS_Define.h

+++ b/fpdfsdk/include/javascript/JS_Define.h

@@ -183,7 +183,7 @@ void js_class_name::JSDestructor(JSFXObject obj) \

int js_class_name::Init(IJS_Runtime* pRuntime, FXJSOBJTYPE eObjType)\

- int nObjDefnID = JS_DefineObj(pRuntime, js_class_name::m_pClassName, eObjType, JSConstructor, JSDestructor, 0);\

+ int nObjDefnID = JS_DefineObj(pRuntime, js_class_name::m_pClassName, eObjType, JSConstructor, JSDestructor);\

if (nObjDefnID >= 0)\

for (int j=0, szj=sizeof(JS_Class_Properties)/sizeof(JSPropertySpec)-1; j<szj; j++)\

@@ -212,7 +212,7 @@ int js_class_name::Init(IJS_Runtime* pRuntime, FXJSOBJTYPE eObjType)\

const wchar_t* js_class_name::m_pClassName = JS_WIDESTRING(class_name);\

int js_class_name::Init(IJS_Runtime* pRuntime, FXJSOBJTYPE eObjType)\

- int nObjDefnID = JS_DefineObj(pRuntime, js_class_name::m_pClassName, eObjType, NULL, NULL, 0);\

+ int nObjDefnID = JS_DefineObj(pRuntime, js_class_name::m_pClassName, eObjType, NULL, NULL);\

if (nObjDefnID >=0)\

for (int i=0, sz=sizeof(JS_Class_Consts)/sizeof(JSConstSpec)-1; i<sz; i++)\

@@ -359,7 +359,7 @@ void js_class_name::JSDestructor(JSFXObject obj) \

int js_class_name::Init(IJS_Runtime* pRuntime, FXJSOBJTYPE eObjType)\

- int nObjDefnID = JS_DefineObj(pRuntime, js_class_name::m_pClassName, eObjType, JSConstructor, JSDestructor, 0);\

+ int nObjDefnID = JS_DefineObj(pRuntime, js_class_name::m_pClassName, eObjType, JSConstructor, JSDestructor);\

if (nObjDefnID >= 0)\

« no previous file with comments | « fpdfsdk/include/formfiller/FFL_FormFiller.h ('k') | fpdfsdk/include/javascript/JS_Runtime.h » ('j') | no next file with comments »