Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1249643002: Fix compilation failure on iOS when RLZ is enabled. (Closed)

Created:
5 years, 5 months ago by sdefresne
Modified:
5 years, 5 months ago
Reviewers:
droger
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compilation failure on iOS when RLZ is enabled. rlz::RLZTracker::GetAccessPointRLZ(rlz::RLZTracker::ChromeOmnibox(), ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ GetAccessPointRlz BUG=511570 Committed: https://crrev.com/c7c85fe8e7966c27a952a62c63b63c4e7eb99c63 Cr-Commit-Position: refs/heads/master@{#339643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/browser/search_engines/ui_thread_search_terms_data.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
PTAL
5 years, 5 months ago (2015-07-21 12:56:48 UTC) #2
droger
lgtm
5 years, 5 months ago (2015-07-21 12:57:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249643002/1
5 years, 5 months ago (2015-07-21 12:57:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 13:17:16 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 13:18:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7c85fe8e7966c27a952a62c63b63c4e7eb99c63
Cr-Commit-Position: refs/heads/master@{#339643}

Powered by Google App Engine
This is Rietveld 408576698