Issue 1249623003: Change ::shadow to * /deep/ to stop relying on implementation bug.

Issue 1249623003: Change ::shadow to * /deep/ to stop relying on implementation bug. (Closed)

Created:
5 years, 5 months ago by Dan Beam

Modified:
5 years, 5 months ago

Reviewers:
esprehn

CC:
chromium-reviews, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Change ::shadow to * /deep/ to stop relying on implementation bug. R=esprehn@chromium.org BUG=511486 Committed: https://crrev.com/d0d043650561bf4f135f483b18157d3033e456b2 Cr-Commit-Position: refs/heads/master@{#339717}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/webui/resources/js/i18n_template_no_process.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (1 generated)

esprehn

lgtm, I think "html /deep/" is technically faster due to some silly implementation stuff, we ...

5 years, 5 months ago (2015-07-21 18:18:18 UTC) #2

Dan Beam

On 2015/07/21 18:18:18, esprehn wrote: > lgtm, I think "html /deep/" is technically faster due ...

5 years, 5 months ago (2015-07-21 18:22:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249623003/1

5 years, 5 months ago (2015-07-21 18:23:25 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-07-21 19:49:13 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d0d043650561bf4f135f483b18157d3033e456b2
Cr-Commit-Position: refs/heads/master@{#339717}