Issue 12496020: Use OutputConfigurator::SetDislpayMode for ctrl-fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12496020: Use OutputConfigurator::SetDislpayMode for ctrl-fullscreen (Closed)

Created:
7 years, 9 months ago by oshima

Modified:
7 years, 9 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use OutputConfigurator::SetDislpayMode for ctrl-fullscreen DisplayManager knows the mirroring state, so no need to rely on OutputConfigurator to move to next state. There is a chance that dislpay may be disconnected when SetDisplayMode, but that's harmless as it simply returns false. BUG=180443 TEST=manual. see bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189738

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -50 lines)			Patch
M	ash/display/display_controller.cc	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	ash/display/display_manager.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/display/display_manager.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chromeos/display/output_configurator.h	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	chromeos/display/output_configurator.cc	View	1 chunk	+0 lines, -39 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12496020/1

7 years, 9 months ago (2013-03-21 17:27:39 UTC) #3

oshima

7 years, 9 months ago (2013-03-22 02:42:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r189738 (presubmit successful).

Expand Messages | Collapse Messages