Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1249553004: Enable CSS Motion Path (Closed)

Created:
5 years, 5 months ago by Eric Willigers
Modified:
5 years, 5 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enable CSS Motion Path Move the motion path properties out from behind the CSSMotionPath flag. Intent to Ship https://groups.google.com/a/chromium.org/d/msg/blink-dev/N4o2MoV1zuw/zKZrE43Mp7EJ Spec https://drafts.fxtf.org/motion-1/ BUG=496518 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199347

Patch Set 1 : virtual/stable/webexposed #

Patch Set 2 : retain CSSMotionPath flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Eric Willigers
noel for platform owner review.
5 years, 5 months ago (2015-07-22 03:36:51 UTC) #4
Noel Gordon
Happy landings, platform LGTM
5 years, 5 months ago (2015-07-22 03:50:56 UTC) #5
Timothy Loh
Leave the flag in and change the status, we can remove the flag once the ...
5 years, 5 months ago (2015-07-22 03:54:46 UTC) #7
Noel Gordon
Do you expect problems with this feature? I suppose better safe than sorry.
5 years, 5 months ago (2015-07-22 04:15:19 UTC) #8
Eric Willigers
On 2015/07/22 03:54:46, Timothy Loh wrote: > Leave the flag in and change the status, ...
5 years, 5 months ago (2015-07-22 05:13:37 UTC) #9
Noel Gordon
Still LGTM
5 years, 5 months ago (2015-07-22 07:10:04 UTC) #10
dstockwell
lgtm
5 years, 5 months ago (2015-07-23 01:49:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249553004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1249553004/60001
5 years, 5 months ago (2015-07-23 01:50:09 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 03:00:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199347

Powered by Google App Engine
This is Rietveld 408576698