include/core/SkPixelRef.h - Issue 1249543003: Creating functions for uploading a mipmapped texture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkPixelRef.h

Issue 1249543003: Creating functions for uploading a mipmapped texture. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Removing the concept of a dirty mipmap. It is expected that the texture upload provides the mipmaps. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkPixelRef.h

diff --git a/include/core/SkPixelRef.h b/include/core/SkPixelRef.h

index 0d9182aae1bf41964771f6b196c04bc18a6a7c95..e3f6c20ed39fbd2ca2a12d33b277d734bd96c41d 100644

--- a/include/core/SkPixelRef.h

+++ b/include/core/SkPixelRef.h

@@ -304,9 +304,6 @@ protected:

// default impl returns NULL.

virtual SkData* onRefEncodedData();

- // default impl does nothing.

- virtual void onNotifyPixelsChanged();

// default impl returns false.

virtual bool onGetYUV8Planes(SkISize sizes[3], void* planes[3], size_t rowBytes[3],

SkYUVColorSpace* colorSpace);