Creating functions for uploading a mipmapped texture.

src/gpu/GrTextureProvider.cpp

-
 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrTextureProvider.h"
 #include "GrTexturePriv.h"
 #include "GrResourceCache.h"
 #include "GrGpu.h"
 
 enum ScratchTextureFlags {
     kExact_ScratchTextureFlag           = 0x1,
     kNoPendingIO_ScratchTextureFlag     = 0x2,
     kNoCreate_ScratchTextureFlag        = 0x4,
 };
 
 GrTexture* GrTextureProvider::createTexture(const GrSurfaceDesc& desc, bool budgeted,
-                                            const void* srcData, size_t rowBytes) {
+                                            const SkTArray<SkMipMapLevel>& texels) {
     if (this->isAbandoned()) {
         return nullptr;
     }
     if ((desc.fFlags & kRenderTarget_GrSurfaceFlag) &&
         !fGpu->caps()->isConfigRenderable(desc.fConfig, desc.fSampleCnt > 0)) {
         return nullptr;
     }
     if (!GrPixelConfigIsCompressed(desc.fConfig)) {
-        static const uint32_t kFlags = kExact_ScratchTextureFlag |
-                                       kNoCreate_ScratchTextureFlag;
-        if (GrTexture* texture = this->refScratchTexture(desc, kFlags)) {
-            if (!srcData || texture->writePixels(0, 0, desc.fWidth, desc.fHeight, desc.fConfig,
-                                                 srcData, rowBytes)) {
-                if (!budgeted) {
-                    texture->resourcePriv().makeUnbudgeted();
+        // In the case of mipmaps, do not use a scratch texture
+        if (texels.count() < 2) {
+            const SkMipMapLevel& baseMipLevel = texels[0];
+            static const uint32_t kFlags = kExact_ScratchTextureFlag |
+                                           kNoCreate_ScratchTextureFlag;
+            if (GrTexture* texture = this->refScratchTexture(desc, kFlags)) {
+                if (texture->writePixels(0, 0, desc.fWidth, desc.fHeight, desc.fConfig,

[bsalomon, 2016/01/08 16:43:29]

This works when writePixels uses an intermediate temporary texture that gets
rendered to texture?

[cblume, 2016/01/09 01:26:56]

I think I don't follow what you are asking.
This path is inside "if (texels.count() < 2) {".
This is the non-mipmap path.
So it should be exactly the same as before this patch.

It is missing the "!srcData ||" prior to writing the pixels. So if the texture
data is null, it would be different. However, inside writePixels we check if the
data is null as well:
https://codereview.chromium.org/1249543003/diff/1210001/src/gpu/GrGpu.cpp

So I believe this should work the way it always has.

Perhaps I should explicitly shortcut if there is no data just for clarity's sake
or because that decision is expected to be made at this level?

[bsalomon, 2016/01/11 17:16:38]

Got it, my misunderstanding.

+                                         baseMipLevel.fTexelsOrOffset, baseMipLevel.fRowBytes)) {
+                    if (!budgeted) {
+                        texture->resourcePriv().makeUnbudgeted();
+                    }
+                    return texture;
                 }
-                return texture;
+                texture->unref();
             }
-            texture->unref();
         }
     }
-    return fGpu->createTexture(desc, budgeted, srcData, rowBytes);
+    return fGpu->createTexture(desc, budgeted, texels);
+}
+
+GrTexture* GrTextureProvider::createTexture(const GrSurfaceDesc& desc, bool budgeted,
+                                            const void* srcData, size_t rowBytes) {
+    SkMipMapLevel level(srcData, rowBytes, desc.fWidth, desc.fHeight);
+    const int mipLevelCount = 1;
+    SkTArray<SkMipMapLevel> texels(mipLevelCount);
+    texels.push_back(level);
+
+    return this->createTexture(desc, budgeted, texels);
 }
 
 GrTexture* GrTextureProvider::createApproxTexture(const GrSurfaceDesc& desc) {
     return this->internalCreateApproxTexture(desc, 0);
 }
 
 GrTexture* GrTextureProvider::internalCreateApproxTexture(const GrSurfaceDesc& desc,
                                                           uint32_t scratchFlags) {
     if (this->isAbandoned()) {
         return nullptr;
@@ skipping 72 matching lines @@
     resource->resourcePriv().setUniqueKey(key);
 }
 
 bool GrTextureProvider::existsResourceWithUniqueKey(const GrUniqueKey& key) const {
     return this->isAbandoned() ? false : fCache->hasUniqueKey(key);
 }
 
 GrGpuResource* GrTextureProvider::findAndRefResourceByUniqueKey(const GrUniqueKey& key) {
     return this->isAbandoned() ? nullptr : fCache->findAndRefUniqueResource(key);
 }