Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1249503002: X87: Debugger: prepare code for debugging on a per-function basis. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Debugger: prepare code for debugging on a per-function basis. port 35c28ce0a742e58346d2dea009428cacd442040d (r29758). original commit message: Prior to this patch, we enter a global debug mode whenever a break point is set. By entering this mode, all code is deoptimized and activated frames are recompiled and redirected to newly compiled debug code. After this patch, we only deoptimize/redirect for functions we want to debug. Trigger for this is Debug::EnsureDebugInfo, and having DebugInfo object attached to the SFI prevents optimization/inlining. The result is that we can have optimized code for functions without break points alongside functions that do have break points, which are not optimized. BUG= Committed: https://crrev.com/65f18c9d6cd8871615c18a0d7af9c2b8838c99c8 Cr-Commit-Position: refs/heads/master@{#29765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/x87/assembler-x87-inl.h View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-21 02:26:23 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-21 02:29:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249503002/1
5 years, 5 months ago (2015-07-21 02:30:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 02:52:24 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 02:52:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65f18c9d6cd8871615c18a0d7af9c2b8838c99c8
Cr-Commit-Position: refs/heads/master@{#29765}

Powered by Google App Engine
This is Rietveld 408576698