Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1249473003: Revert of NaCl cleanup: Split out irt_interfaces.cc from irt_ppapi.cc (Closed)

Created:
5 years, 5 months ago by Ryan Sleevi
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of NaCl cleanup: Split out irt_interfaces.cc from irt_ppapi.cc (patchset #1 id:1 of https://codereview.chromium.org/1244533006/) Reason for revert: Regressed Linux sizes - 4.5% is a bit of a hit to take to bump sizes. If you're absolutely sure this is acceptable, update sizes as well. Original issue's description: > NaCl cleanup: Split out irt_interfaces.cc from irt_ppapi.cc > > The intention here is that irt_interfaces.{cc,h} should list the NaCl > IRT interfaces that we implement in Chromium but that other files > (like irt_ppapi.cc) should implement them. This matches how the files > are organised in native_client/src/untrusted/irt/. > > This is in preparation for copying the PNaCl translator IRT interfaces > to the Chromium side. That will add a couple more interfaces to > irt_interfaces.cc (rather than to irt_ppapi.cc). > > BUG=302078 > TEST=NaCl tests in browser_tests > > Committed: https://crrev.com/5e662010c1f7881970de6de19bcbd50f2726ea00 > Cr-Commit-Position: refs/heads/master@{#339508} TBR=jvoung@chromium.org,bbudge@chromium.org,mseaborn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=302078 Committed: https://crrev.com/db9f0a6b277a39d2f2b70d99e17801a18a6d79a6 Cr-Commit-Position: refs/heads/master@{#339559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -93 lines) Patch
M components/nacl/loader/nonsfi/nonsfi_main.cc View 1 chunk +1 line, -1 line 0 comments Download
D ppapi/nacl_irt/irt_interfaces.h View 1 chunk +0 lines, -15 lines 0 comments Download
D ppapi/nacl_irt/irt_interfaces.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M ppapi/nacl_irt/irt_ppapi.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/nacl_irt/irt_ppapi.cc View 2 chunks +63 lines, -2 lines 0 comments Download
M ppapi/nacl_irt/irt_start.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Sleevi
Created Revert of NaCl cleanup: Split out irt_interfaces.cc from irt_ppapi.cc
5 years, 5 months ago (2015-07-20 23:24:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249473003/1
5 years, 5 months ago (2015-07-20 23:25:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 23:28:03 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/db9f0a6b277a39d2f2b70d99e17801a18a6d79a6 Cr-Commit-Position: refs/heads/master@{#339559}
5 years, 5 months ago (2015-07-20 23:29:44 UTC) #4
Mark Seaborn
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1245893002/ by mseaborn@chromium.org. ...
5 years, 5 months ago (2015-07-21 04:51:20 UTC) #5
Matt Giuca
5 years, 5 months ago (2015-07-21 07:50:08 UTC) #6
Message was sent while issue was closed.
I filed a bug about this regression, please keep it updated:
http://crbug.com/512342.

Powered by Google App Engine
This is Rietveld 408576698