Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1249433004: PPC: Unify "runtime-style" IC functions with Runtime intrinsics (Closed)

Created:
5 years, 5 months ago by MTBrandyberry
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Unify "runtime-style" IC functions with Runtime intrinsics Port bc8041dc2b4c8431c5c2476496acd3b7b8b3f61e Original commit message: Previous to this CL, ICs used a slightly different code idiom to get to C++ code from generated code than runtime intrinsics, using an IC_Utility class that in essence provided exactly the same functionality as Runtime::FunctionForId, but in its own quirky way. This CL unifies the two mechanisms, folding IC_Utility away by making all IC entry points in C++ code, e.g. IC miss handlers, full-fledged runtime intrinsics. This makes it possible to eliminate a bunch of ad-hoc declarations and adapters that the IC system had to needlessly re-invent. As a bonus and the original reason for this yak-shave: IC-related C++ runtime functions are now callable from TurboFan. R=danno@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/1a57cede121f8c09af02f3f3e4959746b179b90b Cr-Commit-Position: refs/heads/master@{#29821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -45 lines) Patch
M src/ic/ppc/handler-compiler-ppc.cc View 7 chunks +9 lines, -20 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 4 chunks +4 lines, -11 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +6 lines, -13 lines 0 comments Download
M src/ppc/debug-ppc.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 5 months ago (2015-07-23 15:22:38 UTC) #1
dstence
lgtm
5 years, 5 months ago (2015-07-23 15:44:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249433004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1249433004/1
5 years, 5 months ago (2015-07-23 15:51:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 16:23:04 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 16:23:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a57cede121f8c09af02f3f3e4959746b179b90b
Cr-Commit-Position: refs/heads/master@{#29821}

Powered by Google App Engine
This is Rietveld 408576698