Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/i18n.cc

Issue 124943004: Prepare removal of ObjectTemplate::New without Isolate parameter. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Do not remove ObjectTemplate::New() yet. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/d8.cc ('k') | test/cctest/test-accessors.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 } 250 }
251 } 251 }
252 252
253 253
254 template<int internal_fields, EternalHandles::SingletonHandle field> 254 template<int internal_fields, EternalHandles::SingletonHandle field>
255 Handle<ObjectTemplateInfo> GetEternal(Isolate* isolate) { 255 Handle<ObjectTemplateInfo> GetEternal(Isolate* isolate) {
256 if (isolate->eternal_handles()->Exists(field)) { 256 if (isolate->eternal_handles()->Exists(field)) {
257 return Handle<ObjectTemplateInfo>::cast( 257 return Handle<ObjectTemplateInfo>::cast(
258 isolate->eternal_handles()->GetSingleton(field)); 258 isolate->eternal_handles()->GetSingleton(field));
259 } 259 }
260 v8::Local<v8::ObjectTemplate> raw_template(v8::ObjectTemplate::New()); 260 v8::Local<v8::ObjectTemplate> raw_template =
261 v8::ObjectTemplate::New(reinterpret_cast<v8::Isolate*>(isolate));
261 raw_template->SetInternalFieldCount(internal_fields); 262 raw_template->SetInternalFieldCount(internal_fields);
262 return Handle<ObjectTemplateInfo>::cast( 263 return Handle<ObjectTemplateInfo>::cast(
263 isolate->eternal_handles()->CreateSingleton( 264 isolate->eternal_handles()->CreateSingleton(
264 isolate, 265 isolate,
265 *v8::Utils::OpenHandle(*raw_template), 266 *v8::Utils::OpenHandle(*raw_template),
266 field)); 267 field));
267 } 268 }
268 269
269 270
270 icu::DecimalFormat* CreateICUNumberFormat( 271 icu::DecimalFormat* CreateICUNumberFormat(
(...skipping 782 matching lines...) Expand 10 before | Expand all | Expand 10 after
1053 1054
1054 1055
1055 void BreakIterator::DeleteBreakIterator( 1056 void BreakIterator::DeleteBreakIterator(
1056 const v8::WeakCallbackData<v8::Value, void>& data) { 1057 const v8::WeakCallbackData<v8::Value, void>& data) {
1057 DeleteNativeObjectAt<icu::BreakIterator>(data, 0); 1058 DeleteNativeObjectAt<icu::BreakIterator>(data, 0);
1058 DeleteNativeObjectAt<icu::UnicodeString>(data, 1); 1059 DeleteNativeObjectAt<icu::UnicodeString>(data, 1);
1059 DestroyGlobalHandle(data); 1060 DestroyGlobalHandle(data);
1060 } 1061 }
1061 1062
1062 } } // namespace v8::internal 1063 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/d8.cc ('k') | test/cctest/test-accessors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698