Source/modules/websockets/WebSocketChannel.cpp - Issue 124943003: Remove 'String::append' from some of the blink source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/WebSocketChannel.cpp

Issue 124943003: Remove 'String::append' from some of the blink source. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removing the CustomFilterValidatedProgram.cpp from the patch(File is deleted in r164847) Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/websockets/WebSocketChannel.cpp

diff --git a/Source/modules/websockets/WebSocketChannel.cpp b/Source/modules/websockets/WebSocketChannel.cpp

old mode 100644

new mode 100755

index a27f64c00d73a59123ca8f272f7e160e20387ec2..5570ac29ec5a6c732177bd798b0aea30fe0a4e39

--- a/Source/modules/websockets/WebSocketChannel.cpp

+++ b/Source/modules/websockets/WebSocketChannel.cpp

@@ -65,8 +65,7 @@ PassRefPtr<WebSocketChannel> WebSocketChannel::create(ExecutionContext* context,

if (context->isWorkerGlobalScope()) {

WorkerGlobalScope* workerGlobalScope = toWorkerGlobalScope(context);

WorkerRunLoop& runLoop = workerGlobalScope->thread()->runLoop();

- String mode = webSocketChannelMode;

- mode.append(String::number(runLoop.createUniqueId()));

+ String mode = webSocketChannelMode + String::number(runLoop.createUniqueId());

return WorkerThreadableWebSocketChannel::create(workerGlobalScope, client, mode, sourceURL, lineNumber);

}

« no previous file with comments | « Source/modules/filesystem/DOMFilePath.cpp ('k') | Source/platform/network/HTTPParsers.cpp » ('j') | no next file with comments »