Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1249423002: Make createCSSImageValueWithReferrer static (Closed)

Created:
5 years, 5 months ago by rwlbuis
Modified:
5 years ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make createCSSImageValueWithReferrer static Make createCSSImageValueWithReferrer static by passing in CSSParserContext. This allows making more helper methods static. BUG=499780 Committed: https://crrev.com/12e1cad08b5e220cb98371e0a272765bdb9ae310 Cr-Commit-Position: refs/heads/master@{#363390}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -33 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 5 chunks +8 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 6 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 5 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rwlbuis
PTAL. This will make the upcoming <image> patch a bit cleaner as well.
5 years ago (2015-12-06 22:13:45 UTC) #5
Timothy Loh
On 2015/12/06 22:13:45, rwlbuis wrote: > PTAL. This will make the upcoming <image> patch a ...
5 years ago (2015-12-06 23:46:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1249423002/20001
5 years ago (2015-12-06 23:49:18 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-07 01:03:33 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-07 01:04:51 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/12e1cad08b5e220cb98371e0a272765bdb9ae310
Cr-Commit-Position: refs/heads/master@{#363390}

Powered by Google App Engine
This is Rietveld 408576698