Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 12494033: Provide a link to restart chrome when changing gpu settings (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
===================================================================
--- chrome/browser/resources/options/browser_options.js (revision 189066)
+++ chrome/browser/resources/options/browser_options.js (working copy)
@@ -467,6 +467,17 @@
}
}
+ // System section.
+ if (!cr.isChromeOS) {
+ $('gpu-mode-reset-restart').style.visibility = 'hidden';
Dan Beam 2013/03/21 02:03:52 you should change this to .hidden = true;
Zhenyao Mo 2013/03/21 21:52:53 Done.
+ $('gpu-mode-checkbox').onclick = function(event) {
Dan Beam 2013/03/21 02:03:52 it seems the code as it is now is slightly subopti
Zhenyao Mo 2013/03/21 21:52:53 This is more complicated. Because a user can modi
Dan Beam 2013/03/21 22:19:27 pref notifications should change the checkbox alre
+ $('gpu-mode-reset-restart').style.visibility = 'visible';
Dan Beam 2013/03/21 02:03:52 and .hidden = false; to avoid invisible text causi
Zhenyao Mo 2013/03/21 21:52:53 Done.
+ };
+ $('gpu-mode-reset-restart-link').onclick = function(event) {
Dan Beam 2013/03/21 02:03:52 event.preventDefault();
Zhenyao Mo 2013/03/21 21:52:53 Done.
+ chrome.send('restartBrowser');
+ };
+ }
+
if (loadTimeData.getBoolean('managedUsersEnabled') &&
loadTimeData.getBoolean('profileIsManaged')) {
$('managed-user-settings-section').hidden = false;

Powered by Google App Engine
This is Rietveld 408576698