Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9333)

Unified Diff: chrome/common/extensions/extension.h

Issue 12494028: Move Requirements out of Extension Class (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 5e1b91756ce89f9325b14feb5c6e90d907f07264..dac6d03664bb799cb6104d9433befdcb65f5247c 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -106,16 +106,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
SYNC_TYPE_APP
};
- // Declared requirements for the extension.
- struct Requirements {
- Requirements();
- ~Requirements();
-
- bool webgl;
- bool css3d;
- bool npapi;
- };
-
// An NaCl module included in the extension.
struct NaClModuleInfo {
GURL url;
@@ -435,7 +425,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// Accessors:
- const Requirements& requirements() const { return requirements_; }
const base::FilePath& path() const { return path_; }
const GURL& url() const { return extension_url_; }
Manifest::Location location() const;
@@ -597,8 +586,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadManifestVersion(string16* error);
bool LoadNaClModules(string16* error);
bool LoadSandboxedPages(string16* error);
- // Must be called after the "plugins" key has been parsed.
- bool LoadRequirements(string16* error);
bool LoadOfflineEnabled(string16* error);
bool LoadExtensionFeatures(string16* error);
bool LoadContentScripts(string16* error);
@@ -673,9 +660,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// the case when we know the manifest version actually is 1.
int manifest_version_;
- // The requirements declared in the manifest.
- Requirements requirements_;
-
// The absolute path to the directory the extension is stored in.
base::FilePath path_;

Powered by Google App Engine
This is Rietveld 408576698