Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc

Issue 12494028: Move Requirements out of Extension Class (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc
deleted file mode 100644
index dde2cf010cd29e81873cf8e95cc44db3f0ad35be..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc
+++ /dev/null
@@ -1,91 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
-
-#include "chrome/common/extensions/extension_manifest_constants.h"
-#include "extensions/common/error_utils.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace errors = extension_manifest_errors;
-
-using extensions::ErrorUtils;
-
-TEST_F(ExtensionManifestTest, RequirementsInvalid) {
- Testcase testcases[] = {
- Testcase("requirements_invalid_requirements.json",
- errors::kInvalidRequirements),
- Testcase("requirements_invalid_keys.json", errors::kInvalidRequirements),
- Testcase("requirements_invalid_3d.json",
- ErrorUtils::FormatErrorMessage(
- errors::kInvalidRequirement, "3D")),
- Testcase("requirements_invalid_3d_features.json",
- ErrorUtils::FormatErrorMessage(
- errors::kInvalidRequirement, "3D")),
- Testcase("requirements_invalid_3d_features_value.json",
- ErrorUtils::FormatErrorMessage(
- errors::kInvalidRequirement, "3D")),
- Testcase("requirements_invalid_3d_no_features.json",
- ErrorUtils::FormatErrorMessage(
- errors::kInvalidRequirement, "3D")),
- Testcase("requirements_invalid_plugins.json",
- ErrorUtils::FormatErrorMessage(
- errors::kInvalidRequirement, "plugins")),
- Testcase("requirements_invalid_plugins_key.json",
- ErrorUtils::FormatErrorMessage(
- errors::kInvalidRequirement, "plugins")),
- Testcase("requirements_invalid_plugins_value.json",
- ErrorUtils::FormatErrorMessage(
- errors::kInvalidRequirement, "plugins"))
- };
-
- RunTestcases(testcases, arraysize(testcases), EXPECT_TYPE_ERROR);
-}
-
-TEST_F(ExtensionManifestTest, RequirementsValid) {
- // Test the defaults.
- scoped_refptr<extensions::Extension> extension(LoadAndExpectSuccess(
- "requirements_valid_empty.json"));
- ASSERT_TRUE(extension.get());
- EXPECT_EQ(extension->requirements().webgl, false);
- EXPECT_EQ(extension->requirements().css3d, false);
- EXPECT_EQ(extension->requirements().npapi, false);
-
- // Test loading all the requirements.
- extension = LoadAndExpectSuccess("requirements_valid_full.json");
- ASSERT_TRUE(extension.get());
- EXPECT_EQ(extension->requirements().webgl, true);
- EXPECT_EQ(extension->requirements().css3d, true);
- EXPECT_EQ(extension->requirements().npapi, true);
-}
-
-// When an npapi plugin is present, the default of the "npapi" requirement
-// changes.
-TEST_F(ExtensionManifestTest, RequirementsNpapiDefault) {
- scoped_refptr<extensions::Extension> extension(LoadAndExpectSuccess(
- "requirements_npapi_empty.json"));
- ASSERT_TRUE(extension.get());
- EXPECT_EQ(extension->requirements().webgl, false);
- EXPECT_EQ(extension->requirements().css3d, false);
- EXPECT_EQ(extension->requirements().npapi, true);
-
- extension = LoadAndExpectSuccess(
- "requirements_npapi_empty_plugins_empty.json");
- ASSERT_TRUE(extension.get());
- EXPECT_EQ(extension->requirements().webgl, false);
- EXPECT_EQ(extension->requirements().css3d, false);
- EXPECT_EQ(extension->requirements().npapi, false);
-
- extension = LoadAndExpectSuccess("requirements_npapi.json");
- ASSERT_TRUE(extension.get());
- EXPECT_EQ(extension->requirements().webgl, false);
- EXPECT_EQ(extension->requirements().css3d, false);
- EXPECT_EQ(extension->requirements().npapi, false);
-
- extension = LoadAndExpectSuccess("requirements_npapi_plugins_empty.json");
- ASSERT_TRUE(extension.get());
- EXPECT_EQ(extension->requirements().webgl, false);
- EXPECT_EQ(extension->requirements().css3d, false);
- EXPECT_EQ(extension->requirements().npapi, true);
-}
« chrome/browser/extensions/extension_browsertest.cc ('K') | « chrome/common/extensions/extension.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698