Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3315)

Unified Diff: chrome/browser/webdata/web_data_service_base.cc

Issue 12494020: Remove knowledge of Chrome-specific SyncableService classes from WebDataService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test in debug mode. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/webdata/web_data_service.cc ('k') | chrome/browser/webdata/web_data_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/webdata/web_data_service_base.cc
diff --git a/chrome/browser/webdata/web_data_service_base.cc b/chrome/browser/webdata/web_data_service_base.cc
index 68650cf688e19ccf846aec8f73f76acd2eccaeae..57891aa14de24c57797554b5410367fb517dbe7b 100644
--- a/chrome/browser/webdata/web_data_service_base.cc
+++ b/chrome/browser/webdata/web_data_service_base.cc
@@ -40,6 +40,9 @@ WebDataServiceBase::WebDataServiceBase(const ProfileErrorCallback& callback)
void WebDataServiceBase::ShutdownOnUIThread() {
db_loaded_ = false;
+ BrowserThread::PostTask(
+ BrowserThread::DB, FROM_HERE,
+ base::Bind(&WebDataServiceBase::ShutdownOnDBThread, this));
ShutdownDatabase();
}
@@ -80,10 +83,23 @@ WebDatabase* WebDataServiceBase::GetDatabase() {
return wdbs_->GetDatabaseOnDB();
}
+base::SupportsUserData* WebDataServiceBase::GetDBUserData() {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
+ if (!db_thread_user_data_)
+ db_thread_user_data_.reset(new SupportsUserDataAggregatable());
+ return db_thread_user_data_.get();
+}
+
WebDataServiceBase::~WebDataServiceBase() {
+ DCHECK(!db_thread_user_data_.get()) << "Forgot to call ShutdownOnUIThread?";
wdbs_.reset();
}
+void WebDataServiceBase::ShutdownOnDBThread() {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
+ db_thread_user_data_.reset();
+}
+
////////////////////////////////////////////////////////////////////////////////
//
// The following methods are executed on the DB thread.
« no previous file with comments | « chrome/browser/webdata/web_data_service.cc ('k') | chrome/browser/webdata/web_data_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698