Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Issue 12494020: Remove knowledge of Chrome-specific SyncableService classes from WebDataService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test in debug mode. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_autofill_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
index 6ffaf1b02888d12816d12250685a554a4b08cae2..f82ba9608cb31dd2e43cb3b9747f0845012265f5 100644
--- a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
@@ -193,21 +193,7 @@ class WebDataServiceFake : public WebDataService {
return 0;
}
- virtual AutocompleteSyncableService*
- GetAutocompleteSyncableService() const OVERRIDE {
- EXPECT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::DB));
- EXPECT_TRUE(autocomplete_syncable_service_);
-
- return autocomplete_syncable_service_;
- }
-
- virtual AutofillProfileSyncableService*
- GetAutofillProfileSyncableService() const OVERRIDE {
- EXPECT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::DB));
- EXPECT_TRUE(autofill_profile_syncable_service_);
-
- return autofill_profile_syncable_service_;
- }
+ virtual void ShutdownOnUIThread() OVERRIDE {}
private:
virtual ~WebDataServiceFake() {}
@@ -215,25 +201,19 @@ class WebDataServiceFake : public WebDataService {
void CreateSyncableService() {
ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::DB));
// These services are deleted in DestroySyncableService().
- autocomplete_syncable_service_ = new AutocompleteSyncableService(this);
- autofill_profile_syncable_service_ =
- new AutofillProfileSyncableService(this);
+ AutocompleteSyncableService::CreateForWebDataService(this);
+ AutofillProfileSyncableService::CreateForWebDataService(this);
syncable_service_created_or_destroyed_.Signal();
}
void DestroySyncableService() {
ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::DB));
- delete autofill_profile_syncable_service_;
- delete autocomplete_syncable_service_;
+ WebDataServiceBase::ShutdownOnDBThread();
syncable_service_created_or_destroyed_.Signal();
}
WebDatabase* web_database_;
- // We own the syncable services, but don't use a |scoped_ptr| because the
- // lifetime must be managed on the DB thread.
- AutocompleteSyncableService* autocomplete_syncable_service_;
- AutofillProfileSyncableService* autofill_profile_syncable_service_;
WaitableEvent syncable_service_created_or_destroyed_;
};
@@ -245,7 +225,7 @@ ACTION_P(MakeAutocompleteSyncComponents, wds) {
EXPECT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::DB));
if (!BrowserThread::CurrentlyOn(BrowserThread::DB))
return base::WeakPtr<syncer::SyncableService>();
- return wds->GetAutocompleteSyncableService()->AsWeakPtr();
+ return AutocompleteSyncableService::FromWebDataService(wds)->AsWeakPtr();
}
ACTION_P(ReturnNewDataTypeManagerWithDebugListener, debug_listener) {
@@ -274,7 +254,7 @@ ACTION_P(MakeAutofillProfileSyncComponents, wds) {
EXPECT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::DB));
if (!BrowserThread::CurrentlyOn(BrowserThread::DB))
return base::WeakPtr<syncer::SyncableService>();;
- return wds->GetAutofillProfileSyncableService()->AsWeakPtr();
+ return AutofillProfileSyncableService::FromWebDataService(wds)->AsWeakPtr();
}
class AbstractAutofillFactory {
« no previous file with comments | « chrome/browser/sync/profile_sync_components_factory_impl.cc ('k') | chrome/browser/webdata/autocomplete_syncable_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698