new style of property/function callbacks

new style of property/function callbacks


R=svenpanne@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=14725

[Michael Starzinger, 2013-03-18 13:57:05]

Just two comments about the naming of the class for the output parameter. The
rest looks sane to me (an Sven).

https://codereview.chromium.org/12494012/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/12494012/diff/1/include/v8.h#newcode2078
include/v8.h:2078: class V8EXPORT ReturnHandler {
As discussed offline: Let's name this class ReturnValue.

https://codereview.chromium.org/12494012/diff/1/include/v8.h#newcode2081
include/v8.h:2081: V8_INLINE(void SetReturnValue(Persistent<T> handle)) { slot_
= *handle; }
As discussed offline: Let's name these setters just Set().

[dcarney, 2013-05-03 13:24:38]

will someone please review me?

[tfarina, 2013-05-03 16:33:46]

https://chromiumcodereview.appspot.com/12494012/diff/28001/src/x64/macro-asse...
File src/x64/macro-assembler-x64.h (right):

https://chromiumcodereview.appspot.com/12494012/diff/28001/src/x64/macro-asse...
src/x64/macro-assembler-x64.h:1230: Address function_address,
super tiny nit: doesn't fit in 80 column above? without having to wrap?

[Sven Panne, 2013-05-07 09:45:05]

lgtm

[Sven Panne, 2013-05-15 12:07:22]

Just for the record: There seem to be some Windows problems, after these are
fixed, this CL can be landed.

[Sven Panne, 2013-05-15 13:36:30]

LGTM again, if a short overview comment is added what the new machinery in
arguments.{h,cc} is actually doing and why it is needed. I really hope a lot of
this stuff will die after a transitional phase, currently it is quite
intimidating...

[dcarney, 2013-05-21 06:36:41]

Committed patchset #19 manually as r14725 (presubmit successful).