Keyboard shortcut to log views, layers, windows

ash/accelerators/accelerator_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/accelerators/accelerator_controller.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 
@@ skipping 256 matching lines @@
 bool HandleMediaPlayPause() {
   Shell::GetInstance()->delegate()->HandleMediaPlayPause();
   return true;
 }
 
 bool HandleMediaPrevTrack() {
   Shell::GetInstance()->delegate()->HandleMediaPrevTrack();
   return true;
 }
 
-#if !defined(NDEBUG)
 bool HandlePrintLayerHierarchy() {
   Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
   for (size_t i = 0; i < root_windows.size(); ++i) {
     ui::PrintLayerHierarchy(root_windows[i]->layer(),
                             root_windows[i]->GetLastMouseLocationInRoot());
   }
   return true;
 }
 
 bool HandlePrintViewHierarchy() {
   aura::Window* active_window = ash::wm::GetActiveWindow();
   if (!active_window)
     return true;
   views::Widget* browser_widget =
       views::Widget::GetWidgetForNativeWindow(active_window);
-  if (browser_widget)
-    views::PrintViewHierarchy(browser_widget->GetRootView());
+  if (!browser_widget)
+    return true;
+  // Error so logs can be collected from end-users.
+  LOG(ERROR) << "View hierarchy:";
+  views::PrintViewHierarchy(browser_widget->GetRootView());
   return true;
 }
 
 void PrintWindowHierarchy(aura::Window* window, int indent) {
   std::string indent_str(indent, ' ');
   std::string name(window->name());
   if (name.empty())
     name = "\"\"";
-  DLOG(INFO) << indent_str << name << " (" << window << ")"
-             << " type=" << window->type()
-             << (wm::IsActiveWindow(window) ? " [active] " : " ")
-             << (window->IsVisible() ? " visible " : " ")
-             << window->bounds().ToString();
+  // Error so logs can be collected from end-users.
+  LOG(ERROR) << indent_str << name << " (" << window << ")"
+      << " type=" << window->type()

[Daniel Erat, 2013/03/16 03:32:23]

nit: fix indenting on this and following lines

[James Cook, 2013/03/16 04:09:24]

Done.

+      << (wm::IsActiveWindow(window) ? " [active] " : " ")
+      << (window->IsVisible() ? " visible " : " ")
+      << window->bounds().ToString();
 
   for (size_t i = 0; i < window->children().size(); ++i)
     PrintWindowHierarchy(window->children()[i], indent + 3);
 }
 
 bool HandlePrintWindowHierarchy() {
-  DLOG(INFO) << "Window hierarchy:";
   Shell::RootWindowControllerList controllers =
       Shell::GetAllRootWindowControllers();
   for (size_t i = 0; i < controllers.size(); ++i) {
-    DLOG(INFO) << "RootWindow " << i << ":";
+    // Error so logs can be collected from end-users.
+    LOG(ERROR) << "RootWindow " << i << ":";
     PrintWindowHierarchy(controllers[i]->root_window(), 0);
   }
   return true;
 }
 
-#endif  // !defined(NDEBUG)
+bool HandlePrintUIHierarchies() {
+  // This is a separate command so the user only has to hit one key to generate
+  // all the logs. Developers use the individual dumps repeatedly, so keep
+  // those as separate commands to avoid spamming their logs.
+  HandlePrintLayerHierarchy();
+  HandlePrintWindowHierarchy();
+  HandlePrintViewHierarchy();
+  return true;
+}
 
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // AcceleratorControllerContext, public:
 
 AcceleratorControllerContext::AcceleratorControllerContext() {
   current_accelerator_.set_type(ui::ET_UNKNOWN);
   previous_accelerator_.set_type(ui::ET_UNKNOWN);
 }
@@ skipping 370 matching lines @@
         // TODO(mazda): Fix crbug.com/158217
         return false;
       }
       if (ime_control_delegate_.get())
         return ime_control_delegate_->HandleNextIme();
       break;
     case PREVIOUS_IME:
       if (ime_control_delegate_.get())
         return ime_control_delegate_->HandlePreviousIme();
       break;
+    case PRINT_UI_HIERARCHIES:
+      return HandlePrintUIHierarchies();
     case SWITCH_IME:
       if (ime_control_delegate_.get())
         return ime_control_delegate_->HandleSwitchIme(accelerator);
       break;
     case SELECT_WIN_0:
       Launcher::ForPrimaryDisplay()->SwitchToWindow(0);
       return true;
     case SELECT_WIN_1:
       Launcher::ForPrimaryDisplay()->SwitchToWindow(1);
       return true;
@@ skipping 175 matching lines @@
     keyboard_brightness_control_delegate) {
   keyboard_brightness_control_delegate_ =
       keyboard_brightness_control_delegate.Pass();
 }
 
 bool AcceleratorController::CanHandleAccelerators() const {
   return true;
 }
 
 }  // namespace ash