src/d8.h - Issue 12494010: Unbreak readline support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.h

Issue 12494010: Unbreak readline support. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/d8.h

diff --git a/src/d8.h b/src/d8.h

index f3b3fa1728e95c8aa6e7ac5c820197bf603b8a66..04c54545516b372c2b6d4471a72a9f026f34dfb5 100644

--- a/src/d8.h

+++ b/src/d8.h

@@ -123,7 +123,7 @@ class LineEditor {

virtual ~LineEditor() { }

virtual Handle<String> Prompt(const char* prompt) = 0;

- virtual bool Open() { return true; }

+ virtual bool Open(Isolate* isolate) { return true; }

virtual bool Close() { return true; }

virtual void AddHistory(const char* str) { }

« no previous file with comments | « no previous file | src/d8.cc » ('j') | no next file with comments »