src/d8.cc - Issue 12494010: Unbreak readline support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.cc

Issue 12494010: Unbreak readline support. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/d8.cc

diff --git a/src/d8.cc b/src/d8.cc

index 2d30a1c39ab84e0de1f2d28d72a9e4207792e46e..24c89e90ae54d8420c7c659219bf01a3050ab71e 100644

--- a/src/d8.cc

+++ b/src/d8.cc

@@ -1497,7 +1497,7 @@ void Shell::RunShell(Isolate* isolate) {

Handle<String> name = String::New("(d8)");

LineEditor* console = LineEditor::Get();

printf("V8 version %s [console: %s]\n", V8::GetVersion(), console->name());

- console->Open();

+ console->Open(isolate);

while (true) {

HandleScope inner_scope;

Handle<String> input = console->Prompt(Shell::kPrompt);

« no previous file with comments | « src/d8.h ('k') | src/d8-readline.cc » ('j') | no next file with comments »