Issue 12494010: Unbreak readline support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12494010: Unbreak readline support. (Closed)

Created:
7 years, 9 months ago by Sven Panne

Modified:
7 years, 9 months ago

Reviewers:
adamk

CC:
v8-dev, tfarina

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Unbreak readline support. Things are still far from being nice, the editor registration/handling in d8 is still embarrassing. Nevertheless things work with readline support again. Fixed a missing Locker on the way. TBR=adamk@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=13909

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -6 lines)			Patch
M	src/d8.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/d8.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/d8-readline.cc	View	5 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

Committed patchset #1 manually as r13909 (presubmit successful).

7 years, 9 months ago (2013-03-12 08:00:26 UTC) #1

tfarina

7 years, 9 months ago (2013-03-16 18:49:43 UTC) #2

Message was sent while issue was closed.

Hey Sven,

Please consider looking into https://github.com/antirez/linenoise for an
alternative.

Thanks,

Expand Messages | Collapse Messages