Fix restoring after a crash.

Fix restoring after a crash.

When opened selected a USB volume in Files app, and crashed, the Files app is tried to be restored with the previous path. However, the volume may not yet be available. In such case, parent is considered. However, parent is /removable, which resolving causes an error, resulting in throwing an exception and going into a wrong state.

In such situation, we should fallback, and this is what this patch does. If the parent is not resolvable, then the fallback is used as the next current directory instead.

Moreover, after recent refactoring a regression has been introduced. When resolving a parent of the initial directory fails, then a wrong variable name was used, what caused a JS error.

TEST=Tested manually on Pixel.
BUG=331587
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243538

[mtomasz, 2014-01-06 08:26:39]

@hirono: PTAL. Thanks!

[hirono, 2014-01-06 10:20:11]

lgtm with a nit. Thank you for fixing it!

https://codereview.chromium.org/124933002/diff/30001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/file_manager.js
(right):

https://codereview.chromium.org/124933002/diff/30001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/file_manager.js:1517:
function() {
We can pass the callback directly.

[mtomasz, 2014-01-07 00:52:10]

https://codereview.chromium.org/124933002/diff/30001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/file_manager.js
(right):

https://codereview.chromium.org/124933002/diff/30001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/file_manager.js:1517:
function() {
On 2014/01/06 10:20:11, hirono wrote:
> We can pass the callback directly.

Done.

[commit-bot: I haz the power, 2014-01-07 00:54:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/124933002/80001

[commit-bot: I haz the power, 2014-01-07 12:26:10]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 01:35:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/124933002/80001

[commit-bot: I haz the power, 2014-01-08 12:46:43]

Change committed as 243538