Issue 124923002: Fix selecting when opening an image from the download shelf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 124923002: Fix selecting when opening an image from the download shelf. (Closed)

Created:
6 years, 11 months ago by mtomasz

Modified:
6 years, 11 months ago

Reviewers:
hirono

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix selecting when opening an image from the download shelf. After migrating fullPaths/URLs to Entries in the gallery, it was assumed that the 'entries' and 'selectedEntries' arrays contain a common subset of Entries by meaning of same references for the same images. However, when opening from the shelf, the selected image's Entry reference is not contained in the 'entries' array. Therefore, we have to lookup by urls instead of references. In general, we should never compare Entries by references. TEST=Tested manually on the download shelf. BUG=331735 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243090

Patch Set 1 #

Patch Set 2 : Fixed a comment. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	chrome/browser/resources/file_manager/foreground/js/photo/gallery.js	View	1	2 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/124923002/30001

6 years, 11 months ago (2014-01-06 13:02:03 UTC) #3

Message was sent while issue was closed.

Change committed as 243090

Expand Messages | Collapse Messages