Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1249113004: Disable C4995 warning about #pragma deprecated (Closed)

Created:
5 years, 5 months ago by brucedawson
Modified:
5 years, 5 months ago
CC:
chromium-reviews, Vitaly Buka (NO REVIEWS)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable C4995 warning about #pragma deprecated We already disable warning C4996 (function was declared deprecated) but with the Windows 10 SDK we also have to disable the very similar warning C4995 (function was marked as #pragma deprecated). It's not clear why there are two mechanisms with two different warnings, but there you are. These are the warnings I saw: printing\backend\win_helper.h(152): warning C4995: 'StartXpsPrintJob': name was marked as #pragma deprecated printing\backend\win_helper.h(160): warning C4995: 'IXpsPrintJob': name was marked as #pragma deprecated printing\backend\win_helper.cc(69): warning C4995: 'IXpsPrintJob': name was marked as #pragma deprecated printing\backend\win_helper.cc(299): warning C4995: 'StartXpsPrintJob': name was marked as #pragma deprecated printing\backend\win_helper.cc(307): warning C4995: 'IXpsPrintJob': name was marked as #pragma deprecated R=thakis@chromium.org BUG=491424 Committed: https://crrev.com/3e5c69bd1c1e8230dc4e481d91d293bb4cee19b9 Cr-Commit-Position: refs/heads/master@{#340157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
brucedawson
Nico, one more step towards VS 2015 and Windows 10 SDK compatibility. Please take a ...
5 years, 5 months ago (2015-07-22 21:46:15 UTC) #1
Nico
lgtm
5 years, 5 months ago (2015-07-23 02:50:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1249113004/1
5 years, 5 months ago (2015-07-23 16:52:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/41986)
5 years, 5 months ago (2015-07-23 17:40:39 UTC) #6
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 5 months ago (2015-07-23 18:14:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1249113004/1
5 years, 5 months ago (2015-07-23 20:35:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 20:41:28 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 20:42:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e5c69bd1c1e8230dc4e481d91d293bb4cee19b9
Cr-Commit-Position: refs/heads/master@{#340157}

Powered by Google App Engine
This is Rietveld 408576698