Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 12491018: Merge 187732 "Don't use magic statics in SincResampler for threa..." (Closed)

Created:
7 years, 9 months ago by DaleCurtis
Modified:
7 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Merge 187732 "Don't use magic statics in SincResampler for threa..." > Don't use magic statics in SincResampler for thread safe init. > > SincResampler uses magic statics for thread safe initialization > of runtime detected SIMD support functions. Sadly, this is not > supported on MSVC++ until VS2012. > > Crash reports seem to indicate that every once in a while this > fails on Windows and kConvolveProc ends up initialized to NULL. > > This patch moves initializtion from once per renderer to once > per SincResampler construction. Not ideal, but there should > never be very many instantiations of this class. Long term > we'll be moving to an SSE baseline which obviates the runtime > selection process. > > BUG=179986 > TEST=media_unittests > > > Review URL: https://chromiumcodereview.appspot.com/12530005 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -32 lines) Patch
M media/base/sinc_resampler.h View 2 chunks +7 lines, -2 lines 0 comments Download
M media/base/sinc_resampler.cc View 5 chunks +27 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
DaleCurtis
7 years, 9 months ago (2013-03-14 22:52:14 UTC) #1
DaleCurtis
7 years, 9 months ago (2013-03-14 22:53:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r188226.

Powered by Google App Engine
This is Rietveld 408576698