Chromium Code Reviews
DescriptionMerge 187732 "Don't use magic statics in SincResampler for threa..."
> Don't use magic statics in SincResampler for thread safe init.
>
> SincResampler uses magic statics for thread safe initialization
> of runtime detected SIMD support functions. Sadly, this is not
> supported on MSVC++ until VS2012.
>
> Crash reports seem to indicate that every once in a while this
> fails on Windows and kConvolveProc ends up initialized to NULL.
>
> This patch moves initializtion from once per renderer to once
> per SincResampler construction. Not ideal, but there should
> never be very many instantiations of this class. Long term
> we'll be moving to an SSE baseline which obviates the runtime
> selection process.
>
> BUG=179986
> TEST=media_unittests
>
>
> Review URL: https://chromiumcodereview.appspot.com/12530005
TBR=dalecurtis@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188226
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|
||||||||||||||||||||||||||||