Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/webdata/web_data_service.h

Issue 12491017: Make WebDataService no longer depend on ProfileKeyedService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/web_data_service.h
diff --git a/chrome/browser/webdata/web_data_service.h b/chrome/browser/webdata/web_data_service.h
index dbfe5c6ecc7253e6b0385926336aa5e63830413d..b8adf8a77b07eb662f9d007918d9ab3fae48e674 100644
--- a/chrome/browser/webdata/web_data_service.h
+++ b/chrome/browser/webdata/web_data_service.h
@@ -23,7 +23,6 @@
#include "chrome/browser/api/webdata/web_data_results.h"
#include "chrome/browser/api/webdata/web_data_service_base.h"
#include "chrome/browser/api/webdata/web_data_service_consumer.h"
-#include "chrome/browser/profiles/refcounted_profile_keyed_service.h"
#include "chrome/browser/search_engines/template_url.h"
#include "chrome/browser/search_engines/template_url_id.h"
#include "chrome/browser/webdata/keyword_table.h"
@@ -104,9 +103,10 @@ struct WDKeywordsResult {
class WebDataServiceConsumer;
class WebDataService
- : public WebDataServiceBase,
- public AutofillWebData,
- public RefcountedProfileKeyedService {
+ : public base::RefCountedThreadSafe<WebDataService,
Jói 2013/03/15 17:40:59 This base will have to move to WebDataServiceBase,
+ content::BrowserThread::DeleteOnUIThread>,
+ public WebDataServiceBase,
+ public AutofillWebData {
public:
// Retrieve a WebDataService for the given context.
static scoped_refptr<WebDataService> FromBrowserContext(
@@ -125,10 +125,9 @@ class WebDataService
// |web_data_service| may be NULL for testing purposes.
static void NotifyOfMultipleAutofillChanges(WebDataService* web_data_service);
- // RefcountedProfileKeyedService override:
// Shutdown the web data service. The service can no longer be used after this
// call.
- virtual void ShutdownOnUIThread() OVERRIDE;
+ void ShutdownOnUIThread();
// Initializes the web data service.
void Init(const base::FilePath& path);

Powered by Google App Engine
This is Rietveld 408576698