Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1249043006: fix truncate call to use extension method (Closed)

Created:
5 years, 5 months ago by Jennifer Messerly
Modified:
5 years, 5 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org, ochafik
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
M lib/runtime/dart/_interceptors.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_internal.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_native_typed_data.js View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/runtime/dart/core.js View 3 chunks +8 lines, -8 lines 0 comments Download
M lib/runtime/dart/math.js View 3 chunks +8 lines, -8 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M test/codegen/expect/DeltaBlue.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/expect.js View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jennifer Messerly
5 years, 5 months ago (2015-07-22 21:46:49 UTC) #2
vsm
lgtm!
5 years, 5 months ago (2015-07-22 21:50:53 UTC) #3
Jennifer Messerly
5 years, 5 months ago (2015-07-22 21:50:56 UTC) #5
Jennifer Messerly
thank you! landing :)
5 years, 5 months ago (2015-07-22 21:52:20 UTC) #7
Jennifer Messerly
5 years, 5 months ago (2015-07-22 21:52:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e1cfec0d483bed6db7b061d7cb85cd1601b090e1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698