Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index a5b060ba6d72365bc2183c9ab0d49973070e0909..c273d4da6a71034fedda0be92a5dada236bd5425 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -970,15 +970,17 @@ TEST_F(RenderViewImplTest, OnImeTypeChanged) {
// Update the IME status and verify if our IME backend sends an IPC message
// to activate IMEs.
- view()->UpdateTextInputType();
+ view()->UpdateTextInputState(
+ RenderWidget::NO_SHOW_IME, RenderWidget::FROM_NON_IME);
const IPC::Message* msg = render_thread_->sink().GetMessageAt(0);
EXPECT_TRUE(msg != NULL);
- EXPECT_EQ(ViewHostMsg_TextInputTypeChanged::ID, msg->type());
- ViewHostMsg_TextInputTypeChanged::Param params;
- ViewHostMsg_TextInputTypeChanged::Read(msg, &params);
- ui::TextInputType type = base::get<0>(params);
- ui::TextInputMode input_mode = base::get<1>(params);
- bool can_compose_inline = base::get<2>(params);
+ EXPECT_EQ(ViewHostMsg_TextInputStateChanged::ID, msg->type());
+ ViewHostMsg_TextInputStateChanged::Param params;
+ ViewHostMsg_TextInputStateChanged::Read(msg, &params);
+ ViewHostMsg_TextInputState_Params p = base::get<0>(params);
+ ui::TextInputType type = p.type;
+ ui::TextInputMode input_mode = p.mode;
+ bool can_compose_inline = p.can_compose_inline;
EXPECT_EQ(ui::TEXT_INPUT_TYPE_TEXT, type);
EXPECT_EQ(true, can_compose_inline);
@@ -990,13 +992,15 @@ TEST_F(RenderViewImplTest, OnImeTypeChanged) {
// Update the IME status and verify if our IME backend sends an IPC message
// to de-activate IMEs.
- view()->UpdateTextInputType();
+ view()->UpdateTextInputState(
+ RenderWidget::NO_SHOW_IME, RenderWidget::FROM_NON_IME);
msg = render_thread_->sink().GetMessageAt(0);
EXPECT_TRUE(msg != NULL);
- EXPECT_EQ(ViewHostMsg_TextInputTypeChanged::ID, msg->type());
- ViewHostMsg_TextInputTypeChanged::Read(msg, & params);
- type = base::get<0>(params);
- input_mode = base::get<1>(params);
+ EXPECT_EQ(ViewHostMsg_TextInputStateChanged::ID, msg->type());
+ ViewHostMsg_TextInputStateChanged::Read(msg, &params);
+ p = base::get<0>(params);
+ type = p.type;
+ input_mode = p.mode;
EXPECT_EQ(ui::TEXT_INPUT_TYPE_PASSWORD, type);
for (size_t i = 0; i < arraysize(kInputModeTestCases); i++) {
@@ -1012,13 +1016,15 @@ TEST_F(RenderViewImplTest, OnImeTypeChanged) {
// Update the IME status and verify if our IME backend sends an IPC
// message to activate IMEs.
- view()->UpdateTextInputType();
+ view()->UpdateTextInputState(
+ RenderWidget::NO_SHOW_IME, RenderWidget::FROM_NON_IME);
const IPC::Message* msg = render_thread_->sink().GetMessageAt(0);
EXPECT_TRUE(msg != NULL);
- EXPECT_EQ(ViewHostMsg_TextInputTypeChanged::ID, msg->type());
- ViewHostMsg_TextInputTypeChanged::Read(msg, & params);
- type = base::get<0>(params);
- input_mode = base::get<1>(params);
+ EXPECT_EQ(ViewHostMsg_TextInputStateChanged::ID, msg->type());
+ ViewHostMsg_TextInputStateChanged::Read(msg, &params);
+ p = base::get<0>(params);
+ type = p.type;
+ input_mode = p.mode;
EXPECT_EQ(test_case->expected_mode, input_mode);
}
}
@@ -1145,7 +1151,8 @@ TEST_F(RenderViewImplTest, ImeComposition) {
// Update the status of our IME back-end.
// TODO(hbono): we should verify messages to be sent from the back-end.
- view()->UpdateTextInputType();
+ view()->UpdateTextInputState(
+ RenderWidget::NO_SHOW_IME, RenderWidget::FROM_NON_IME);
ProcessPendingMessages();
render_thread_->sink().ClearMessages();
@@ -1952,7 +1959,7 @@ TEST_F(RenderViewImplTest, MessageOrderInDidChangeSelection) {
for (size_t i = 0; i < render_thread_->sink().message_count(); ++i) {
const uint32 type = render_thread_->sink().GetMessageAt(i)->type();
- if (type == ViewHostMsg_TextInputTypeChanged::ID) {
+ if (type == ViewHostMsg_TextInputStateChanged::ID) {
is_input_type_called = true;
last_input_type = i;
} else if (type == ViewHostMsg_SelectionChanged::ID) {
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698